Support objects as ScalaDsl definitions. #156
Conversation
When ${baseDir} gets interpolated on Windows the traditional double-quote
delimiters make for a malformed String literal.
Go go abusive reflection.
| @@ -84,12 +84,12 @@ import gherkin.I18n | |||
|
|
|||
| def _ = File.separator | |||
| def engine = new SimpleTemplateEngine() | |||
| def templateSource = new File("${basedir}${_}src${_}main${_}code_generator${_}I18n.groovy.txt").getText() | |||
| def templateSource = new File(/${basedir}${_}src${_}main${_}code_generator${_}I18n.groovy.txt/).getText() | |||
There was a problem hiding this comment.
This must be some Groovy syntax I'm unfamiliar with. Can you explain?
There was a problem hiding this comment.
The Groovy User Guide calls it "Slashy String literals". It makes '/' the only escape sequence recognized inside the literal making it safe for interpolating Windows file names and since the antrun plugin doesn't sanitize ${baseDir} it's the only option for making it work cleanly under Windows. I haven't had a chance to check it under Linux so I isolated those changes so people can cherry pick around them.
There was a problem hiding this comment.
@dwskoog hmm, I get errors on OS X with those changes. If you pop into #cucumber on irc.freenode.net we can discuss it.
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This is what I worked up to make objects behave themselves a bit better than what @teigen and I noticed in #154