Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CDI2] Add CDI2 integration #1626

Merged
merged 2 commits into from May 18, 2019
Merged

[CDI2] Add CDI2 integration #1626

merged 2 commits into from May 18, 2019

Conversation

rmannibucau
Copy link
Contributor

Summary

OpenWebBeans PR looks outdated now CDI 2 has a dedicated API to manage a container.
Note it also unify weld module so it can likely be removed after some deprecation time.
To be complete the deltaspike module should stay a bit for CDI 1.x containers.

Details

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

  • I've added tests for my code.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@coveralls
Copy link

coveralls commented May 10, 2019

Coverage Status

Coverage increased (+0.06%) to 85.905% when pulling f5eb672 on rmannibucau:cdi2 into b8ecde7 on cucumber:master.

Copy link
Contributor

@mpkorstanje mpkorstanje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers. Looks pretty solid. Could you add a minimal read me that covers:

  1. Dependencies needed
  2. Which annotations (if any) should be used.
  3. Anything else needed to make https://github.com/cucumber/cucumber-java-skeleton work with CDI.

cdi2/pom.xml Outdated
<dependencies>
<dependency>
<groupId>io.cucumber</groupId>
<artifactId>cucumber-java</artifactId>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just merged #1615. By implementing io.cucumber.core.backend.ObjectFactory only a dependency on cucumber-core is needed.

@@ -0,0 +1,4 @@
package cucumber.api.cdi2;

public class README {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this do?

@mpkorstanje
Copy link
Contributor

mpkorstanje commented May 12, 2019

Looks like the build is failing on Java 11. This can be solved by adding a dependency on:

    <groupId>javax.annotation</groupId>
    <artifactId>javax.annotation-api</artifactId>

@rmannibucau
Copy link
Contributor Author

@mpkorstanje just pushed a commit, hopefully fixing all comments - and thanks a lot for the catches up!

@mpkorstanje mpkorstanje changed the title adding cdi2 integration [Core] Add CDI2 integration May 18, 2019
@mpkorstanje mpkorstanje merged commit f9300bd into cucumber:master May 18, 2019
@aslakhellesoy
Copy link
Contributor

Hi @rmannibucau,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

  • ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
  • 💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
  • 💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
  • ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
  • 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team,
Aslak Hellesøy
Creator of Cucumber

@mpkorstanje
Copy link
Contributor

Cheers!

@mpkorstanje mpkorstanje changed the title [Core] Add CDI2 integration [CDI2] Add CDI2 integration May 18, 2019
@rmannibucau rmannibucau deleted the cdi2 branch May 19, 2019 09:11
@lock
Copy link

lock bot commented May 20, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

1 similar comment
@lock
Copy link

lock bot commented May 20, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
@aslakhellesoy
Copy link
Contributor

Hi @rmannibucau,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

  • ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
  • 💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
  • 💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
  • ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
  • 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team,
Aslak Hellesøy
Creator of Cucumber

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants