-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve release instructions #2103
Conversation
I really feel like we could add some unit tests on `scripts/update-changelog.sh. Some kind of golden testing ones where we have input files and expected outputs for many different changelog files would be easy to maintain. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
Don't forget to copy this to:
I really feel like we could add some unit tests on `scripts/update-changelog.sh. Some kind of golden testing ones where we have input files and expected outputs for many different changelog files would be easy to maintain.
This script is executed in the docker container so it could be added to the docker image. And as part of building the image some tests could be added. This would also remove the duplication I mentioned above.
The docker image is kept in:
I think we're good to go now. |
Is your pull request related to a problem? Please describe.
While releasing Cucumber-JVM 6.6.0, we ran into some issues:
pom.xml
, which made the release process because versions in root pom and submodules pom do not matchupdate-changelog.sh
scriptOverall the overall release process went smoothly. Anyway we think we can improve it even further.
Describe the solution you have implemented
update-changelog.sh
more robust and runnable on osx