Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Datatable] Support boolean parsing in Datatables #2614

Merged
merged 1 commit into from Sep 15, 2022
Merged

[Datatable] Support boolean parsing in Datatables #2614

merged 1 commit into from Sep 15, 2022

Conversation

gaeljw
Copy link
Member

@gaeljw gaeljw commented Sep 14, 2022

🤔 What's changed?

Aims to fix #2611

Added a TableCellTransformer for Boolean and boolean which replacable.

⚡️ What's your motivation?

N/A

🏷️ What kind of change is this?

  • ⚡ New feature (non-breaking change which adds new behaviour)

♻️ Anything particular you want feedback on?

N/A

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

@codecov
Copy link

codecov bot commented Sep 14, 2022

Codecov Report

Merging #2614 (dca9bfa) into main (823c380) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               main    #2614   +/-   ##
=========================================
  Coverage     84.72%   84.72%           
  Complexity     2696     2696           
=========================================
  Files           320      320           
  Lines          9512     9515    +3     
  Branches        908      908           
=========================================
+ Hits           8059     8062    +3     
  Misses         1123     1123           
  Partials        330      330           
Impacted Files Coverage Δ
...a/io/cucumber/datatable/DataTableTypeRegistry.java 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mpkorstanje mpkorstanje changed the title feat: 🚀 Support boolean parsing in Datatables [Core] Support boolean parsing in Datatables Sep 15, 2022
@mpkorstanje mpkorstanje changed the title [Core] Support boolean parsing in Datatables [Datatable] Support boolean parsing in Datatables Sep 15, 2022
@mpkorstanje mpkorstanje merged commit 3ea5401 into main Sep 15, 2022
@mpkorstanje mpkorstanje deleted the gh2611 branch September 15, 2022 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UndefinedDataTableTypeException with Boolean
2 participants