[Spring] Inject CucumberContextConfiguration constructor dependencies #2664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpkorstanje
force-pushed
the
spring-inject-cucumber-context-configuration-dependencies
branch
from
4b8d712
to
13f319f
Compare
In #2661 classes annotated with `@CucumberContextConfiguration` were created as beans directly from the bean factory. This allowed them to be prepared as test instances by JUnit. However, we did not tell the factory that it should autowire constructor dependencies resulting in #2663. Additionally, because beans were created directly from the bean factory, they were not added to the application context. This meant that while dependencies could be injected into them, they could not be injected into other objects. Fixes: #2663
mpkorstanje
force-pushed
the
spring-inject-cucumber-context-configuration-dependencies
branch
from
13f319f
to
1a55e41
Compare
Codecov Report
@@ Coverage Diff @@
## main #2664 +/- ##
=========================================
Coverage 84.81% 84.82%
Complexity 2693 2693
=========================================
Files 322 322
Lines 9570 9573 +3
Branches 905 905
=========================================
+ Hits 8117 8120 +3
Misses 1121 1121
Partials 332 332
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
mpkorstanje
deleted the
spring-inject-cucumber-context-configuration-dependencies
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π€ What's changed?
In #2661 classes annotated with
@CucumberContextConfigurationwere created as beans directly from the bean factory. This allowed them to be prepared as test instances by JUnit. However, we did not tell the factory that it should autowire constructor dependencies resulting in #2663.Additionally, because beans were created directly from the bean factory, they were not added to the application context. This meant that while dependencies could be injected into them, they could not be injected into other objects.
Fixes: #2663
π·οΈ What kind of change is this?
π Checklist: