Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Warn when cucumber.options is used #2685

Merged
merged 1 commit into from
Jan 15, 2023

Conversation

mpkorstanje
Copy link
Contributor

@mpkorstanje mpkorstanje commented Jan 15, 2023

🤔 What's changed?

In #1779 we deprecated and removed cucumber.options. Unfortunately there are a slew of outdated tutorials still in existence. And this outdated knowledge creates a slow trickle of questions on StackOverflow. It would be nice if we can stop this waste of everyone's time.

Fixes: #2673

🏷️ What kind of change is this?

  • ⚡ New feature (non-breaking change which adds new behaviour)

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

@mpkorstanje mpkorstanje force-pushed the warn-when-cucumber-options-is-used branch from e91deac to bc2adaf Compare January 15, 2023 12:50
In #1779 we deprecated and removed cucumber.options. Unfortunately
there are a slew of outdated tutorials still in existence. And this
outdated knowledge creates a slow trickle of questions on
StackOverflow. It would be nice if we can stop this waste of everyone's
time.

Fixes: #2673
@mpkorstanje mpkorstanje force-pushed the warn-when-cucumber-options-is-used branch from bc2adaf to 86c2290 Compare January 15, 2023 12:50
@mpkorstanje mpkorstanje marked this pull request as ready for review January 15, 2023 12:52
@codecov
Copy link

codecov bot commented Jan 15, 2023

Codecov Report

Merging #2685 (86c2290) into main (35c71f0) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               main    #2685   +/-   ##
=========================================
  Coverage     84.67%   84.68%           
- Complexity     2679     2680    +1     
=========================================
  Files           322      322           
  Lines          9444     9450    +6     
  Branches        899      899           
=========================================
+ Hits           7997     8003    +6     
  Misses         1120     1120           
  Partials        327      327           
Impacted Files Coverage Δ
...ucumber/core/options/CucumberPropertiesParser.java 96.00% <100.00%> (+0.34%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mpkorstanje mpkorstanje merged commit ad47dd5 into main Jan 15, 2023
@mpkorstanje mpkorstanje deleted the warn-when-cucumber-options-is-used branch January 15, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warn when cucumber.options is used
1 participant