Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #2827

Merged
merged 1 commit into from
Dec 11, 2023
Merged

Update README.md #2827

merged 1 commit into from
Dec 11, 2023

Conversation

bischoffdev
Copy link
Contributor

🤔 What's changed?

Added Cucable to JUnit platform engine readme

⚡️ What's your motivation?

Cucable was not yet included in the tools for JUnit platform engine.

🏷️ What kind of change is this?

Readme addition

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

Added Cucable to JUnit platform engine readme
Copy link

codecov bot commented Dec 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (854394d) 84.95% compared to head (46c0a3a) 84.95%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2827   +/-   ##
=========================================
  Coverage     84.95%   84.95%           
  Complexity     2724     2724           
=========================================
  Files           331      331           
  Lines          9539     9539           
  Branches        916      916           
=========================================
  Hits           8104     8104           
  Misses         1110     1110           
  Partials        325      325           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mpkorstanje
Copy link
Contributor

I can see how Cucable allows users to work around the lack of support for JUnit 5 in Maven by generating suite classes. But most examples use JUnit 4. Do you think you could update the documentation of Cucable to include how it works with JUnit 5?

@bischoffdev
Copy link
Contributor Author

That makes sense, I will add this soon.

@mpkorstanje mpkorstanje merged commit a8288e9 into main Dec 11, 2023
9 checks passed
@mpkorstanje mpkorstanje deleted the bischoffdev-patch-1 branch December 11, 2023 19:12
@mpkorstanje
Copy link
Contributor

Cheers. Then lets not block this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants