[JUnit Platform Engine] @SelectPackages not @SelectClasspathResource #2858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SelectClasspathResource is intended to be used for single resources whereas SelectPackages is intended for packages in those resources. Currently, it doesn't matter because Cucumber is smart enough to scan everything given a directory. But we may want to change that in the future when we use JUnits EngineDiscoveryRequestResolver API.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2858 +/- ##
=========================================
Coverage 84.99% 84.99%
Complexity 2734 2734
=========================================
Files 331 331
Lines 9559 9559
Branches 918 918
=========================================
Hits 8125 8125
Misses 1109 1109
Partials 325 325 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
@SelectClasspathResourceis intended to be used for single resources whereas@SelectPackagesis intended for packages containing those resources.Currently, it doesn't matter because Cucumber is smart enough to scan everything given a directory. But we may want to change that in the future when we use JUnits
EngineDiscoveryRequestResolverAPI (#2835).🏷️ What kind of change is this?