Scenario Outlines: Replace tokens in the names of the generated "Example Scenario"s

[jamiewastin]

My changes are best illustrated with the following example scenario:

Scenario Outline: Time offset check for <LOCATION_NAME>
 Given my local country is <LOCATION_NAME>
 When I compare the time difference to GMT
 Then the time offset should be <OFFSET>

 Examples: 
  | LOCATION_NAME | OFFSET |
  | London        | 1      |
  | New York      | 4      |
  | San Fran      | 8      |

I was hoping in the generated report would have the LOCATION_NAME token substituted for the value of the example being run in the scenario outline name. However this is not happening - and each scenario outline has the name verbatim from the above: Scenario Outline: Time offset check for <LOCATION_NAME>.

This change simply runs the scenario name through CucumberScenarioOutline.replaceTokens(...) method to replace the tokens with the relevant values for each "Scenario Example" that is generated.

Fixes #510.

[aslakhellesoy]

Please see formatting rules in CONTRIBUTING.md - 4 space indent.

[jamiewastin]

@aslakhellesoy - My apologies, consider them corrected!

[jamiewastin]

Side note, I've realised that there is an open issue on this. So the implementation of this should close-out #510

[brasmusson]

Why move the import?

[jamiewastin]

Fixed in latest commit.

[jamiewastin]

OK guys, I've fixed all the indentation and imports - I've rebased and re-pushed the changes. So hopefully this pull request is now a single commit that we're all happy with? :-)

[aslakhellesoy]

I'm usually ok with rearranged imports - I don't want us to appear too strict :-)

Great patch and thanks for finding the related issue as well! @brasmusson do you want to merge this one in?

[brasmusson]

Yes, I can take care of the merging of this one.

My comment on the import was maybe a little picky. The big risk I can see is that the "helpfulness" of our different IDE's makes the import to be rearranged to different standards every other commit (static imports first, static imports last, ...)

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.