Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RuntimeOptions should also clobber the formatters #643

Conversation

brasmusson
Copy link
Contributor

When overriding the arguments from the command line/@CucumberOptions annotation with cucumber.options system property, all options that can hold multiple value are clobbered if provided in system property, except for the formatters option. That is the glue paths, the feature paths and the tag/line/name filters are clobbered if provided in the system property, but not the formatters.

That the formatters should also be formatters is indicated in the Specify a different formatter section of the ReadMe file of the example java-helloworld. The current behaviour is more accurately describes as "Specify an additional formatter".

@aslakhellesoy
Copy link
Contributor

Thanks Björn, but we're actually rely on this feature in Cucumber Pro. Cucumber Pro will enable the CucumberPro formatter by adding a line in cucumber.properties. This allows the formatter to run regardless of what the user has set.

More info here: https://github.com/cucumber-ltd/cucumber-pro-jvm

@brasmusson
Copy link
Contributor Author

I could be a bit confusing that the overriding behavior is different for the "--format", compared to glue, tags and features, see for instance this comment (and reply).

At least documentation like in cucumber-java-skeleton, should be updated to read "Specify an additional formatter"

If judging consistency is important, an alternative would be to add an "--add-format" option for Cucumber Pro to use (and make "--format" clobber formatters).

@aslakhellesoy
Copy link
Contributor

@lock
Copy link

lock bot commented Oct 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants