Obsolete warning about config.cache_classes to false

[diabolo]

Warning contains reference to lighthouse issue tracker

WARNING: You have set Rails' config.cache_classes to false (most likely in
config/environments/cucumber.rb).  This setting is known to cause problems with
database transactions. Set config.cache_classes to true if you want to use
transactions.  For more information see
https://rspec.lighthouseapp.com/projects/16211/tickets/165.

[diabolo]

Comment is in lib/rails.rb:17. This was around before the move to Rails 3. I'd quite like to get rid of this code altogether, but I'm not sure of the consequences. My reason for wanting to remove the code is that the Spring gem has to run with config.cache_classes false (see rails/spring#210 (comment)).

If we can't remove the warning because it is still relevant, then at least we could update the message and explain what problems could happen, perhaps linking to something in the main cucumber docs

Many thanks

Andrew

[Kosmas]

Hi @diabolo,

I am not sure if it is a good idea to remove the code, but maybe @mattwynne @aslakhellesoy @tooky @os97673 have a different opinion?

As for the comment I do not see any problem updating to point to relevant information.

If you can fork the main master repo and can have the tests passing in travis, you can do a PR, and would be happy to merge that back into the main branch.

If you would like to do that, make sure you change the .travis.yml to your forked repo for the notifications and add an entry to the HIstory.md file.

[diabolo]

Hi Kosmas

Unfortunately I can't even get bundler to install gems on the cuke-rails repo. Otherwise I would have tried to make a pull request for this. Hopefully someone with a bit more knowledge about this can contribute.

[Kosmas]

Hi Andrew,

yes it seems there is a few issues trying to fork and run the tests. Will have a look at this first and try to sort out.

[mattwynne]

On 11 Nov 2013, at 11:50, Andrew Premdas notifications@github.com wrote:

Unfortunately I can't even get bundler to install gems on the cuke-rails repo. Otherwise I would have tried to make a pull request for this.

We really must sort this out as highest priority. Otherwise the load of maintenance falls on just a few people.

[Kosmas]

@mattwynne yes I agree.

Just made a few changes on my fork, but most of the tests are failing on the:

Then it should pass(fail) with:

Has something changed in aruba that causes that?

[mattwynne]

Not that I'm aware of. Can you push it into a branch so I can see the failures on travis?

[Kosmas]

Have forked the master branch here and after a few gem version changes the tests pass all fine:

https://travis-ci.org/Kosmas/cucumber-rails/builds/13914901

but when I try to run it on my dev pc I get the errors (line 43 and below in gist):

https://gist.github.com/Kosmas/7450285

So I suppose it's my local issue, but any ideas are welcome.