Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Support Rails 5.2.X #376

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ branches:
- master

gemfile:
- gemfiles/rails_5_2.gemfile
- gemfiles/rails_5_1.gemfile
- gemfiles/rails_5_0.gemfile
- gemfiles/rails_4_2.gemfile
Expand Down
16 changes: 16 additions & 0 deletions Appraisals
Original file line number Diff line number Diff line change
Expand Up @@ -80,3 +80,19 @@ appraise "rails_5_1" do
# Rails 5 requires database cleaner 1.1
gem "database_cleaner", ">= 1.1.0"
end

appraise "rails_5_2" do
gem "rails", "~> 5.2.0"
gem "railties", "~> 5.2.0"
gem 'capybara', '>= 2.15', '< 4.0'
gem "selenium-webdriver", "~> 3.9.0"
gem "geckodriver-helper", "~> 0.0.4"
gem "rspec-rails", "~> 3.5.0"
gem "sass-rails", "~> 5.0"
gem "coffee-rails", "~> 4.2.0"
gem "uglifier", "~> 3.2.0"
gem "sqlite3", "~> 1.3.13"
# Rails 5 requires database cleaner 1.1
gem "database_cleaner", ">= 1.1.0"
gem 'bootsnap', '>= 1.1.0', require: false
end
4 changes: 2 additions & 2 deletions cucumber-rails.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@ Gem::Specification.new do |s|

s.license = 'MIT'

s.add_runtime_dependency('capybara', ['>= 1.1.2', '< 3'])
s.add_runtime_dependency('capybara', ['>= 1.1.2', '< 4'])
s.add_runtime_dependency('cucumber', ['>= 3.0.2', '< 4'])
s.add_runtime_dependency('nokogiri', '~> 1.5')
s.add_runtime_dependency('railties', ['>= 4', '< 5.2'])
s.add_runtime_dependency('railties', ['>= 4', '< 5.3'])
s.add_runtime_dependency('mime-types', ['>= 1.17', '< 4'])

# Main development dependencies
Expand Down
6 changes: 5 additions & 1 deletion features/step_definitions/cucumber_rails_steps.rb
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,10 @@ def install_cucumber_rails(*options)
gem 'selenium-webdriver', group: :test
end

# if Gem.loaded_specs['rails'].version >= Gem::Version.new('5.2.0')
# gem 'bootsnap', require: false
# end

gem 'geckodriver-helper', group: :test
gem 'rspec-rails', group: :test
gem 'database_cleaner', group: :test unless options.include?(:no_database_cleaner)
Expand Down Expand Up @@ -100,7 +104,7 @@ def fixture(path)
Capybara.register_driver :selenium do |app|
browser_options = ::Selenium::WebDriver::Firefox::Options.new()
browser_options.args << '--headless'

Capybara::Selenium::Driver.new(app, browser: :firefox, options: browser_options)
end
}
Expand Down
18 changes: 18 additions & 0 deletions gemfiles/rails_5_2.gemfile
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
# This file was generated by Appraisal

source "https://rubygems.org"

gem "rails", "~> 5.2.0"
gem "railties", "~> 5.2.0"
gem "capybara", ">= 2.15", "< 4.0"
gem "selenium-webdriver", "~> 3.9.0"
gem "geckodriver-helper", "~> 0.0.4"
gem "rspec-rails", "~> 3.5.0"
gem "sass-rails", "~> 5.0"
gem "coffee-rails", "~> 4.2.0"
gem "uglifier", "~> 3.2.0"
gem "sqlite3", "~> 1.3.13"
gem "database_cleaner", ">= 1.1.0"
gem "bootsnap", ">= 1.1.0", require: false

gemspec path: "../"