Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rubocop bump to new majors #504

Merged
merged 4 commits into from Apr 16, 2021
Merged

rubocop bump to new majors #504

merged 4 commits into from Apr 16, 2021

Conversation

luke-hill
Copy link
Contributor

Summary

Bump rubocop rspec and rubocop to new majors Fix up all TODO offenses

Details

Update rubocop

Motivation and Context

Fix up old tech debt

How Has This Been Tested?

CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

  • I've added tests for my code.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@luke-hill luke-hill merged commit e8f4401 into master Apr 16, 2021
@luke-hill luke-hill deleted the refactor/bump_rubocop_vers branch April 16, 2021 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@luke-hill