Add support for alternative select boxes date field helpers #535
Conversation
| fill_in options[:from], with: DateTime.parse(datetime) | ||
| else | ||
| select_date(datetime, options) | ||
| select_time(datetime, options) | ||
| extended_options = options.merge(base_dom_id: base_dom_id) |
There was a problem hiding this comment.
Can you explain this bit here. Everything else is fine
There was a problem hiding this comment.
It's an optimization. I'm passing down base_dom_id to select_date and select_time so they don't need to find the label and extract the select/input id again.
There was a problem hiding this comment.
Ah right I've spotted it now. It's not really extending the options, that's where I got confused. It's added the existing dom id to the options hash and then adding a guard clause to the get_base_dom_from_options method.
Although I'm not sure what I'd call it though. I think this area needs a lot of TLC and fixes but for now this will do. Thanks for explanation
I'm adding another spec forcing select boxes view helper. The helper has been around since Rails 5. It's not a problem to run the test in older versions
mgrunberg
force-pushed
the
add-date-input-support
branch
from
6918456
to
409152f
Compare
|
@luke-hill any chance this could be released soon? we're currently pinning to a commit: alphagov/whitehall@aa2b56b |
|
Probably in a couple of days if nothing else comes in |
Summary
Fixes #534
Rails 7 changed default scaffold datetime helper from
datetime_selecttodatetime_field. PR #526 forces capybara helper to work only withdatetime_field. That's fine for this gem feature specs but not for other projects.This PR adds the ability to work with both helpers.
Details
I'm adding another spec forcing select boxes to view helper. Both
datetime_selectanddatetime_fieldhavebeen around since Rails 5.