Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rubocop-rspec requirement from ~> 2.2.0 to ~> 2.10.0 #547

Merged
merged 1 commit into from
Jun 23, 2022

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 9, 2022

Updates the requirements on rubocop-rspec to permit the latest version.

Release notes

Sourced from rubocop-rspec's releases.

RuboCop RSpec v2.10.0

  • Fix a false positive for RSpec/EmptyExampleGroup when expectations in case statement. (@​ydah)
  • Add RSpec/VerifiedDoubleReference cop. (@​t3h2mas)
  • Make RSpec/BeNil cop configurable with a be_nil style and a be style. (@​bquorning)
  • Fix Capybara/CurrentPathExpectation autocorrect incompatible with Style/TrailingCommaInArguments autocorrect. (@​ydah)
Changelog

Sourced from rubocop-rspec's changelog.

2.10.0 (2022-04-19)

  • Fix a false positive for RSpec/EmptyExampleGroup when expectations in case statement. ([@​ydah][])
  • Add RSpec/VerifiedDoubleReference cop. ([@​t3h2mas][])
  • Make RSpec/BeNil cop configurable with a be_nil style and a be style. ([@​bquorning][])
  • Fix Capybara/CurrentPathExpectation autocorrect incompatible with Style/TrailingCommaInArguments autocorrect. ([@​ydah][])

2.9.0 (2022-02-28)

2.8.0 (2022-01-24)

  • Fix RSpec/FactoryBot/SyntaxMethods and RSpec/Capybara/FeatureMethods to inspect shared groups. ([@​pirj][])
  • Fix RSpec/LeadingSubject failure in non-spec code. ([@​pirj][])
  • Add bad example to RSpec/SubjectStub cop. ([@​oshiro3][])
  • Replace non-styleguide cops StyleGuide attribute with Reference. ([@​pirj][])
  • Fix RSpec/SubjectStub to disallow stubbing of subjects defined in parent example groups. ([@​pirj][])

2.7.0 (2021-12-26)

2.6.0 (2021-11-08)

  • Fix merging RSpec DSL configuration from third-party gems. ([@​pirj][])
  • Fix RSpec/ExcessiveDocstringSpacing false positive for multi-line indented strings. ([@​G-Rath][])
  • Fix Include configuration for sub-departments. ([@​pirj][])
  • Ignore heredocs in RSpec/ExcessiveDocstringSpacing. ([@​G-Rath][])
  • Stop RSpec/ExampleWording from trying to correct heredocs. ([@​G-Rath][])
  • Add autocorrect support for RSpec/VariableDefinition. ([@​r7kamura][])

2.5.0 (2021-09-21)

  • Declare autocorrect as unsafe for ExpectChange. ([@​francois-ferrandis][])
  • Fix each example for RSpec/HookArgument. ([@​lokhi][])
  • Exclude unrelated Rails directories from RSpec/DescribeClass. ([@​MothOnMars][])
  • Add RSpec/ExcessiveDocstringSpacing cop. ([@​G-Rath][])
  • Add RSpec/SubjectDeclaration cop. ([@​dswij][])
  • Fix excessive whitespace removal in RSpec/EmptyHook autocorrection. ([@​pirj][])
  • Bump RuboCop requirement to v1.19.0. ([@​pirj][])
  • Fix false positive in RSpec/IteratedExpectation when there is single, non-expectation statement in the block body. ([@​Darhazer][])

2.4.0 (2021-06-09)

  • Update RSpec/FilePath to check suffix when given a non-constant top-level node (e.g. features). ([@​topalovic][])
  • Add missing documentation for single_statement_only style of RSpec/ImplicitSubject cop. ([@​tejasbubane][])
  • Fix an exception in DescribedClass when accessing a constant on a variable in a spec that is nested in a namespace. ([@​rrosenblum][])

... (truncated)

Commits
  • 4dc8bcc Merge pull request #1260 from rubocop/release
  • dcda511 Bump version to 2.10.0
  • 5e62066 Merge pull request #1257 from rubocop/configure-rspec-examplelength-cop-inter...
  • a123509 Count heredocs as one line in ExampleLength
  • 1f2503b Merge pull request #1253 from ydah/fix-capybara-current-path-expectation-auto...
  • eaeadbb [Fix #1237] Fix Capybara/CurrentPathExpectation autocorrect incompatible wi...
  • d0de0b7 Merge pull request #1251 from rubocop/configurable-be-nil
  • 7949379 Make RSpec/BeNil cop configurable
  • b56d287 Merge pull request #1246 from t3h2mas/verified_doubles_class_reference
  • 1ec40e3 Add VerifiedDoubleReference cop
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the 🤖 dependencies Dependency upgrade label Jun 9, 2022
Copy link
Contributor

@mathieujobin mathieujobin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and lets trashed 2.5.8 from the build matrix

@@ -22,7 +22,7 @@ Gem::Specification.new do |s|
}

s.add_runtime_dependency('capybara', ['>= 2.18', '< 4']) # We support legacy capybara (But only the last 2.x)
s.add_runtime_dependency('cucumber', ['>= 3.2', '< 8']) # Support cucumber in the 3.x <-> 7.x revision range
s.add_runtime_dependency('cucumber', '>= 3.2', '< 9') # Support cucumber in the 3.x <-> 7.x revision range
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm

@dependabot dependabot bot force-pushed the dependabot/bundler/rubocop-rspec-tw-2.10.0 branch from 1270e7f to 3a0947b Compare June 21, 2022 08:37
@luke-hill
Copy link
Contributor

This should go in after other stuff. Owing to the nature of the workflow changes.

cc/ @olleolleolle

@dependabot dependabot bot force-pushed the dependabot/bundler/rubocop-rspec-tw-2.10.0 branch from 3a0947b to 327320f Compare June 21, 2022 11:39
Updates the requirements on [rubocop-rspec](https://github.com/rubocop/rubocop-rspec) to permit the latest version.
- [Release notes](https://github.com/rubocop/rubocop-rspec/releases)
- [Changelog](https://github.com/rubocop/rubocop-rspec/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop-rspec@v2.2.0...v2.10.0)

---
updated-dependencies:
- dependency-name: rubocop-rspec
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/bundler/rubocop-rspec-tw-2.10.0 branch from 327320f to e0a4f48 Compare June 23, 2022 09:35
@olleolleolle olleolleolle merged commit 4c613fe into main Jun 23, 2022
@olleolleolle olleolleolle deleted the dependabot/bundler/rubocop-rspec-tw-2.10.0 branch June 23, 2022 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 dependencies Dependency upgrade
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants