Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: build failures #548

Merged
merged 8 commits into from
Jun 21, 2022
Merged

bugfix: build failures #548

merged 8 commits into from
Jun 21, 2022

Conversation

luke-hill
Copy link
Contributor

@luke-hill luke-hill commented Jun 20, 2022

Summary

Build failures fix - Primarily related to a couple of gems not liking ruby2 vs ruby3 syntax

Details

  • Fix up Appraisals build contexts
  • Add new guards
  • Double check version decrements for old version support

Motivation and Context

Fix stuff

How Has This Been Tested?

CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

  • I've added tests for my code.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@luke-hill luke-hill added rails-5.x rails-6.x 🍼 incomplete Blocked until more information is provided labels Jun 20, 2022
@luke-hill luke-hill removed the 🍼 incomplete Blocked until more information is provided label Jun 20, 2022
@olleolleolle
Copy link
Contributor

🥇 Awesome fixing!

@luke-hill
Copy link
Contributor Author

First of a few PR's to come in to fix things.

@luke-hill luke-hill merged commit b3d0ba2 into main Jun 21, 2022
@luke-hill luke-hill deleted the bugfix/build_failures branch June 21, 2022 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants