Refactor/rubocop autofix part1 (#257)

* Tag initial state

* AF: Layout/ArrayAlignment

* AF: Layout/ClosingHeredocIndentation

* AF: 3x Layout Empty Line cops

* AF: EmptyLinesAroundClassBody and ModuleBody

* Autofixed 3x Indentation layout cops

* AF: Layout/SpaceInsideBlockBraces and SpaceInsideArrayLiteralBrackets

* AF: Lint/RedundantStringCoercion

* AF: UnusedMethodArgument and UnusedBlockArg

* AF: RSpec/ContextMethod

* AF 3x EmptyLine rspec cops

* AF: RSpec/ReceiveCounts

* AF: Style/ClassAndModuleChildren

* AF: Style/NumericLiterals

* AF: 4 different redundant style cops

* AF: Style/SpecialGlobalVars

* AF: 3 x Trailing Comma items and close off part1 for the todo

* regenned todo file

.rubocop_todo.yml

@@ -1,11 +1,14 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2023-09-06 10:22:09 UTC using RuboCop version 1.27.0.
+# on 2023-09-07 17:19:02 UTC using RuboCop version 1.27.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
+# TODO: [LH] Initial state -> 53 files inspected, 2221 offenses detected, 1663 offenses auto-correctable
+# TODO: [LH] Part 1 iteration -> 53 files inspected, 1990 offenses detected, 1442 offenses auto-correctable
+
 # Offense count: 1
 # This cop supports safe auto-correction (--auto-correct).
 # Configuration parameters: TreatCommentsAsGroupSeparators, ConsiderPunctuation, Include.
@@ -14,20 +17,6 @@ Gemspec/OrderedDependencies:
   Exclude:
     - 'cucumber-core.gemspec'
 
-# Offense count: 2
-# This cop supports safe auto-correction (--auto-correct).
-# Configuration parameters: EnforcedStyle, IndentationWidth.
-# SupportedStyles: with_first_element, with_fixed_indentation
-Layout/ArrayAlignment:
-  Exclude:
-    - 'spec/cucumber/core_spec.rb'
-
-# Offense count: 2
-# This cop supports safe auto-correction (--auto-correct).
-Layout/ClosingHeredocIndentation:
-  Exclude:
-    - 'spec/cucumber/core/gherkin/writer_spec.rb'
-
 # Offense count: 4
 # This cop supports safe auto-correction (--auto-correct).
 # Configuration parameters: EnforcedStyle.
@@ -48,27 +37,6 @@ Layout/EmptyLineAfterGuardClause:
     - 'lib/cucumber/core/test/result.rb'
     - 'lib/cucumber/core/test/step.rb'
 
-# Offense count: 42
-# This cop supports safe auto-correction (--auto-correct).
-Layout/EmptyLineAfterMagicComment:
-  Enabled: false
-
-# Offense count: 1
-# This cop supports safe auto-correction (--auto-correct).
-Layout/EmptyLines:
-  Exclude:
-    - 'lib/cucumber/core/event.rb'
-
-# Offense count: 13
-# This cop supports safe auto-correction (--auto-correct).
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: around, only_before
-Layout/EmptyLinesAroundAccessModifier:
-  Exclude:
-    - 'lib/cucumber/core/gherkin/writer.rb'
-    - 'lib/cucumber/core/gherkin/writer/helpers.rb'
-    - 'lib/cucumber/core/test/around_hook.rb'
-
 # Offense count: 30
 # This cop supports safe auto-correction (--auto-correct).
 # Configuration parameters: EnforcedStyle.
@@ -90,42 +58,7 @@ Layout/EmptyLinesAroundBlockBody:
     - 'spec/cucumber/core/test/step_spec.rb'
     - 'spec/cucumber/core_spec.rb'
 
-# Offense count: 19
-# This cop supports safe auto-correction (--auto-correct).
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: empty_lines, empty_lines_except_namespace, empty_lines_special, no_empty_lines, beginning_only, ending_only
-Layout/EmptyLinesAroundClassBody:
-  Exclude:
-    - 'lib/cucumber/core/event.rb'
-    - 'lib/cucumber/core/events.rb'
-    - 'lib/cucumber/core/test/data_table.rb'
-    - 'lib/cucumber/core/test/filters/locations_filter.rb'
-    - 'lib/cucumber/core/test/filters/name_filter.rb'
-    - 'lib/cucumber/core/test/filters/tag_filter.rb'
-    - 'lib/cucumber/core/test/runner.rb'
-    - 'spec/cucumber/core/test/filters/locations_filter_spec.rb'
-
-# Offense count: 19
-# This cop supports safe auto-correction (--auto-correct).
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: empty_lines, empty_lines_except_namespace, empty_lines_special, no_empty_lines
-Layout/EmptyLinesAroundModuleBody:
-  Exclude:
-    - 'lib/cucumber/core.rb'
-    - 'lib/cucumber/core/event_bus.rb'
-    - 'lib/cucumber/core/events.rb'
-    - 'lib/cucumber/core/filter.rb'
-    - 'lib/cucumber/core/gherkin/writer.rb'
-    - 'lib/cucumber/core/gherkin/writer/helpers.rb'
-    - 'lib/cucumber/core/test/action.rb'
-    - 'lib/cucumber/core/test/filters/activate_steps_for_self_test.rb'
-    - 'lib/cucumber/core/test/filters/locations_filter.rb'
-    - 'lib/cucumber/core/test/location.rb'
-    - 'spec/cucumber/core/event_bus_spec.rb'
-    - 'spec/cucumber/core/event_spec.rb'
-    - 'spec/cucumber/core/test/action_spec.rb'
-
-# Offense count: 6
+# Offense count: 5
 # This cop supports safe auto-correction (--auto-correct).
 # Configuration parameters: AllowForAlignment, AllowBeforeTrailingComments, ForceEqualSignAlignment.
 Layout/ExtraSpacing:
@@ -134,30 +67,6 @@ Layout/ExtraSpacing:
     - 'spec/cucumber/core/test/runner_spec.rb'
     - 'spec/cucumber/core/test/step_spec.rb'
 
-# Offense count: 8
-# This cop supports safe auto-correction (--auto-correct).
-# Configuration parameters: IndentationWidth.
-# SupportedStyles: special_inside_parentheses, consistent, align_brackets
-Layout/FirstArrayElementIndentation:
-  EnforcedStyle: consistent
-
-# Offense count: 2
-# This cop supports safe auto-correction (--auto-correct).
-# Configuration parameters: IndentationWidth.
-# SupportedStyles: special_inside_parentheses, consistent, align_braces
-Layout/FirstHashElementIndentation:
-  EnforcedStyle: align_braces
-
-# Offense count: 2
-# This cop supports safe auto-correction (--auto-correct).
-# Configuration parameters: AllowMultipleStyles, EnforcedHashRocketStyle, EnforcedColonStyle, EnforcedLastArgumentHashStyle.
-# SupportedHashRocketStyles: key, separator, table
-# SupportedColonStyles: key, separator, table
-# SupportedLastArgumentHashStyles: always_inspect, always_ignore, ignore_implicit, ignore_explicit
-Layout/HashAlignment:
-  Exclude:
-    - 'cucumber-core.gemspec'
-
 # Offense count: 7
 # This cop supports safe auto-correction (--auto-correct).
 # Configuration parameters: AllowDoxygenCommentStyle, AllowGemfileRubyComment.
@@ -197,29 +106,6 @@ Layout/SpaceAroundOperators:
   Exclude:
     - 'cucumber-core.gemspec'
 
-# Offense count: 16
-# This cop supports safe auto-correction (--auto-correct).
-# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBrackets.
-# SupportedStyles: space, no_space, compact
-# SupportedStylesForEmptyBrackets: space, no_space
-Layout/SpaceInsideArrayLiteralBrackets:
-  Exclude:
-    - 'spec/cucumber/core/test/data_table_spec.rb'
-    - 'spec/cucumber/core/test/runner_spec.rb'
-    - 'spec/cucumber/core_spec.rb'
-
-# Offense count: 8
-# This cop supports safe auto-correction (--auto-correct).
-# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces, SpaceBeforeBlockParameters.
-# SupportedStyles: space, no_space
-# SupportedStylesForEmptyBraces: space, no_space
-Layout/SpaceInsideBlockBraces:
-  Exclude:
-    - 'lib/cucumber/core/test/data_table.rb'
-    - 'spec/cucumber/core/event_bus_spec.rb'
-    - 'spec/cucumber/core/test/action_spec.rb'
-    - 'spec/cucumber/core/test/result_spec.rb'
-
 # Offense count: 735
 # This cop supports safe auto-correction (--auto-correct).
 # Configuration parameters: EnforcedStyle.
@@ -261,36 +147,12 @@ Lint/EmptyBlock:
     - 'spec/cucumber/core/test/runner_spec.rb'
     - 'spec/cucumber/core/test/step_spec.rb'
 
-# Offense count: 1
-# This cop supports safe auto-correction (--auto-correct).
-Lint/RedundantStringCoercion:
-  Exclude:
-    - 'lib/cucumber/core/test/location.rb'
-
 # Offense count: 2
 Lint/RescueException:
   Exclude:
     - 'lib/cucumber/core/test/action.rb'
     - 'lib/cucumber/core/test/around_hook.rb'
 
-# Offense count: 23
-# This cop supports safe auto-correction (--auto-correct).
-# Configuration parameters: IgnoreEmptyBlocks, AllowUnusedKeywordArguments.
-Lint/UnusedBlockArgument:
-  Exclude:
-    - 'spec/cucumber/core/test/runner_spec.rb'
-
-# Offense count: 22
-# This cop supports safe auto-correction (--auto-correct).
-# Configuration parameters: AllowUnusedKeywordArguments, IgnoreEmptyMethods, IgnoreNotImplementedMethods.
-Lint/UnusedMethodArgument:
-  Exclude:
-    - 'lib/cucumber/core/test/around_hook.rb'
-    - 'lib/cucumber/core/test/empty_multiline_argument.rb'
-    - 'lib/cucumber/core/test/location.rb'
-    - 'lib/cucumber/core/test/result.rb'
-    - 'lib/cucumber/core/test/runner.rb'
-
 # Offense count: 2
 Lint/UselessAssignment:
   Exclude:
@@ -351,14 +213,7 @@ Naming/RescuedExceptionsVariableName:
     - 'lib/cucumber/core/test/action.rb'
     - 'lib/cucumber/core/test/around_hook.rb'
 
-# Offense count: 2
-# This cop supports safe auto-correction (--auto-correct).
-RSpec/ContextMethod:
-  Exclude:
-    - 'spec/cucumber/core/event_bus_spec.rb'
-    - 'spec/cucumber/core/test/doc_string_spec.rb'
-
-# Offense count: 49
+# Offense count: 47
 # Configuration parameters: Prefixes.
 # Prefixes: when, with, without
 RSpec/ContextWording:
@@ -384,28 +239,6 @@ RSpec/ContextWording:
 RSpec/DescribedClass:
   Enabled: false
 
-# Offense count: 4
-# This cop supports safe auto-correction (--auto-correct).
-# Configuration parameters: AllowConsecutiveOneLiners.
-RSpec/EmptyLineAfterExample:
-  Exclude:
-    - 'spec/cucumber/core/test/result_spec.rb'
-    - 'spec/cucumber/core_spec.rb'
-
-# Offense count: 2
-# This cop supports safe auto-correction (--auto-correct).
-RSpec/EmptyLineAfterExampleGroup:
-  Exclude:
-    - 'spec/cucumber/core/test/result_spec.rb'
-
-# Offense count: 5
-# This cop supports safe auto-correction (--auto-correct).
-RSpec/EmptyLineAfterFinalLet:
-  Exclude:
-    - 'spec/cucumber/core/test/case_spec.rb'
-    - 'spec/cucumber/core/test/result_spec.rb'
-    - 'spec/cucumber/core/test/runner_spec.rb'
-
 # Offense count: 60
 # Configuration parameters: CountAsOne.
 RSpec/ExampleLength:
@@ -500,14 +333,6 @@ RSpec/PredicateMatcher:
     - 'spec/cucumber/core/test/case_spec.rb'
     - 'spec/cucumber/core/test/result_spec.rb'
 
-# Offense count: 5
-# This cop supports safe auto-correction (--auto-correct).
-RSpec/ReceiveCounts:
-  Exclude:
-    - 'spec/cucumber/core/compiler_spec.rb'
-    - 'spec/cucumber/core/filter_spec.rb'
-    - 'spec/cucumber/core_spec.rb'
-
 # Offense count: 2
 RSpec/RepeatedDescription:
   Exclude:
@@ -572,23 +397,6 @@ Style/CaseEquality:
   Exclude:
     - 'lib/cucumber/core/test/data_table.rb'
 
-# Offense count: 10
-# This cop supports safe auto-correction (--auto-correct).
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: nested, compact
-Style/ClassAndModuleChildren:
-  Exclude:
-    - 'spec/cucumber/core/compiler_spec.rb'
-    - 'spec/cucumber/core/filter_spec.rb'
-    - 'spec/cucumber/core/gherkin/writer_spec.rb'
-    - 'spec/cucumber/core/report/summary_spec.rb'
-    - 'spec/cucumber/core/test/duration_matcher.rb'
-    - 'spec/cucumber/core/test/filters/locations_filter_spec.rb'
-    - 'spec/cucumber/core/test/location_spec.rb'
-    - 'spec/cucumber/core/test/result_spec.rb'
-    - 'spec/cucumber/core/test/runner_spec.rb'
-    - 'spec/cucumber/core/test/step_spec.rb'
-
 # Offense count: 1
 # This cop supports safe auto-correction (--auto-correct).
 Style/EachWithObject:
@@ -668,12 +476,6 @@ Style/MultilineBlockChain:
   Exclude:
     - 'lib/cucumber/core/event_bus.rb'
 
-# Offense count: 7
-# This cop supports safe auto-correction (--auto-correct).
-# Configuration parameters: Strict, AllowedNumbers.
-Style/NumericLiterals:
-  MinDigits: 16
-
 # Offense count: 2
 # This cop supports unsafe auto-correction (--auto-correct-all).
 # Configuration parameters: EnforcedStyle, IgnoredMethods.
@@ -723,31 +525,6 @@ Style/RaiseArgs:
     - 'lib/cucumber/core/test/case.rb'
     - 'spec/cucumber/core/test/runner_spec.rb'
 
-# Offense count: 1
-# This cop supports safe auto-correction (--auto-correct).
-Style/RedundantBegin:
-  Exclude:
-    - 'lib/cucumber/core/test/data_table.rb'
-
-# Offense count: 1
-# This cop supports safe auto-correction (--auto-correct).
-Style/RedundantCondition:
-  Exclude:
-    - 'lib/cucumber/core/test/action.rb'
-
-# Offense count: 1
-# This cop supports safe auto-correction (--auto-correct).
-# Configuration parameters: AllowMultipleReturnValues.
-Style/RedundantReturn:
-  Exclude:
-    - 'lib/cucumber/core/test/result.rb'
-
-# Offense count: 4
-# This cop supports safe auto-correction (--auto-correct).
-Style/RedundantSelf:
-  Exclude:
-    - 'lib/cucumber/core/event.rb'
-
 # Offense count: 2
 # This cop supports safe auto-correction (--auto-correct).
 # Configuration parameters: EnforcedStyle, AllowInnerSlashes.
@@ -780,13 +557,6 @@ Style/SoleNestedConditional:
     - 'lib/cucumber/core/test/doc_string.rb'
     - 'lib/cucumber/core/test/result.rb'
 
-# Offense count: 1
-# This cop supports safe auto-correction (--auto-correct).
-# Configuration parameters: RequireEnglish.
-# SupportedStyles: use_perl_names, use_english_names
-Style/SpecialGlobalVars:
-  EnforcedStyle: use_perl_names
-
 # Offense count: 386
 # This cop supports safe auto-correction (--auto-correct).
 # Configuration parameters: EnforcedStyle, ConsistentQuotesInMultiline.
@@ -816,30 +586,6 @@ Style/SymbolProc:
     - 'lib/cucumber/core/compiler.rb'
     - 'spec/cucumber/core/test/runner_spec.rb'
 
-# Offense count: 1
-# This cop supports safe auto-correction (--auto-correct).
-# Configuration parameters: EnforcedStyleForMultiline.
-# SupportedStylesForMultiline: comma, consistent_comma, no_comma
-Style/TrailingCommaInArguments:
-  Exclude:
-    - 'lib/cucumber/core/events.rb'
-
-# Offense count: 3
-# This cop supports safe auto-correction (--auto-correct).
-# Configuration parameters: EnforcedStyleForMultiline.
-# SupportedStylesForMultiline: comma, consistent_comma, no_comma
-Style/TrailingCommaInArrayLiteral:
-  Exclude:
-    - 'spec/cucumber/core_spec.rb'
-
-# Offense count: 1
-# This cop supports safe auto-correction (--auto-correct).
-# Configuration parameters: EnforcedStyleForMultiline.
-# SupportedStylesForMultiline: comma, consistent_comma, no_comma
-Style/TrailingCommaInHashLiteral:
-  Exclude:
-    - 'cucumber-core.gemspec'
-
 # Offense count: 1
 # This cop supports safe auto-correction (--auto-correct).
 # Configuration parameters: ExactNameMatch, AllowPredicates, AllowDSLWriters, IgnoreClassMethods, AllowedMethods.

Rakefile

@@ -1,9 +1,10 @@
 # encoding: utf-8
+
 require 'rubygems'
 require 'bundler'
 Bundler::GemHelper.install_tasks
 
-$:.unshift File.expand_path("../lib", __FILE__)
+$LOAD_PATH.unshift File.expand_path("../lib", __FILE__)
 
 require 'rubocop/rake_task'
 RuboCop::RakeTask.new