The location abstraction for test steps from scenario outlines is too limited #149
Labels
🧷 pinned
Tells Stalebot not to close this issue
Comments
6 tasks
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs. |
stale
bot
added
the
⌛ stale
stale
bot
removed
the
⌛ stale
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this issue
Sep 23, 2018
## [3.2.0](cucumber/cucumber-ruby-core@v3.1.0...v3.2.0) ### Added * Add the GherkinSourceParsedEvent ([#155](cucumber/cucumber-ruby-core#155) @brasmusson) * Add #original_location to Cucumber::Core::Ast::Step and Cucumber::Core::Test::Step ([#150](cucumber/cucumber-ruby-core#150), [#149](cucumber/cucumber-ruby-core#149) @brasmusson) ### Fixed * Set message and backtrace for undefined result also when skipping (@brasmusson)
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Summary
The location abstraction for a test step from a scenario outline is too limited. Both the location of the outline step and the example table row instantiating the scenario outline is relevant for a test step and should be easily accessible from the test step. A Pickle steps created by the Gherkin compiler for steps of scenario outlines contains both the location of the outline step and the location of the example table row instantiating the scenario outline.
Expected Behavior
Cucumber-Ruby-Core should support that both the location of the outline step and the example table row instantiating the scenario outline is easily accessible, by for instance formatters, of test steps from scenario outlines.
Current Behavior
Currently Cucumber-Ruby-Core defines the single location of a test steps from scenario outlines as the location of the example table row instantiating the scenario outline. This has caused a regression compared to Cucumber-Ruby v1.x.x in both the Pretty Formatter and the Json Formatter (see cucumber/cucumber-ruby#1108).
Possible Solution
For instance define a method
#original_locationthat forExpandedOutlineSteps return the location of theOutlineStepit was expanded from, and that forSteps return the same location as the#locationmethod.Steps to Reproduce (for bugs)
See cucumber/cucumber-ruby#1108.
Context & Motivation
To be able to fix the regressions from Cucumber-Ruby v1.x.x.
Note
Also for test cases from scenario outlines the location abstraction similarly limited, but that is not causing any regressions.
The text was updated successfully, but these errors were encountered: