Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force cucumber-message version to 6.x #184

Merged
merged 1 commit into from Nov 21, 2019
Merged

Conversation

vincent-psarga
Copy link
Contributor

Summary

Until we can support cucumber-messages 7, we'll force the use of the 6.0 releases.

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I've added tests for my code
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Copy link
Contributor

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This helps users avoid getting stuck with versions not supported.

@aslakhellesoy
Copy link
Contributor

The reason for this change is to be able to make releases of dependent libraries (cucumber-messages in this case) without breaking libraries that depend on them (cucumber-ruby-core in this case).

We'll update cucumber-ruby-core to use the latest version of cucumber-messages in due course.

@vincent-psarga vincent-psarga merged commit ee5fc43 into master Nov 21, 2019
@luke-hill luke-hill deleted the pin-message-to-6x branch January 6, 2020 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants