Make the result objects usable in the new formatter api #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set the message on undefined results and append the backtrace with the backtrace line of the step on results that either have an exception (with backtrace) or have a backtrace themselves. Support applying filters on the backtrace.
Somehow a scenario in a wire feature file in Cucumber failed with a timeout error when copying the object and its backtrace.
|
This deep copying of the backtrace resulted in a timeout error in one of the wire scenario of Cucumber, so a resorted to modify the backtrace in place (instead of treating the result object as immutable). |
mattwynne
added a commit
that referenced
this pull request
May 4, 2015
Make the result objects usable in the new formatter api
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make the result objects usable in the new formatter api:
Required by cucumber/common#843.