Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make wire compatible with html formatter #57

Merged
merged 6 commits into from
Jan 7, 2022

Conversation

aurelien-reeves
Copy link
Contributor

@aurelien-reeves aurelien-reeves commented Dec 27, 2021

Description

Fixes #56

It seems that the wire protocol is not compatible with the html formatter.

Note to other contributors

Tests seems to be failing due to the usage of hooks in the wire plugin and how they are managed by new formatters using messages.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • I have added tests to cover my changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

@aurelien-reeves
Copy link
Contributor Author

I may have found a fix: emitting the hook_test_step_created when adding the hooks filter.

Bonus: when working on that, I was able to remove the only use to cucumber::messages, thus the dependency to messages itself.

@aurelien-reeves
Copy link
Contributor Author

This is still a draft because it may be refactored, and also I would prefer having your opinions @luke-hill @mattwynne

@canmor would you have the possibility to take a look? That should actually fix your issue reported in #56

@aurelien-reeves aurelien-reeves marked this pull request as ready for review January 6, 2022 08:33
@aurelien-reeves
Copy link
Contributor Author

Well, actually it was not really finished, sorry 😅

@aurelien-reeves aurelien-reeves merged commit 8b0c9ec into main Jan 7, 2022
@aurelien-reeves aurelien-reeves deleted the fix-step-definition branch January 7, 2022 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cucumber crash with wire protocol while output format is html
2 participants