Fix 'attach' when passing null byte in the data (#1536)

CHANGELOG.md

@@ -16,9 +16,14 @@ Please visit [cucumber/CONTRIBUTING.md](https://github.com/cucumber/cucumber/blo
 
 ### Fixed
 
+- `attach` can now handle null bytes in the data.
+  ([1536](https://github.com/cucumber/cucumber-ruby/pull/1536)
+   [1529](https://github.com/cucumber/cucumber-ruby/issues/1529)
+   [aurelien-reeves](https://github.com/aurelien-reeves))
+
 ### Changed
 
-- The JSON formatter now reports empty scenarios. 
+- The JSON formatter now reports empty scenarios.
   No status is reported for empty scenarios in the resulting JSON.
   No more empty background is reported with empty scenarios.
   ([1533](https://github.com/cucumber/cucumber-ruby/pull/1533)

lib/cucumber/glue/proto_world.rb

@@ -95,6 +95,8 @@ def attach(file, media_type = nil)
         media_type = MIME::Types.type_for(file).first if media_type.nil?
 
         super(content, media_type.to_s)
+      rescue StandardError
+        super
       end
 
       # Mark the matched step as pending.

spec/cucumber/glue/proto_world_spec.rb

@@ -127,6 +127,41 @@ module Glue
           end
         end
       end
+
+      describe 'Handling attachments in step definitions' do
+        extend Cucumber::Formatter::SpecHelperDsl
+        include Cucumber::Formatter::SpecHelper
+
+        before(:each) do
+          Cucumber::Term::ANSIColor.coloring = false
+          @out = StringIO.new
+          @formatter = Cucumber::Formatter::Pretty.new(actual_runtime.configuration.with_options(out_stream: @out, source: false))
+          run_defined_feature
+        end
+
+        describe 'when attaching data with null byte' do
+          define_feature <<-FEATURE
+            Feature: Banana party
+
+              Scenario: Monkey eats banana
+                When some data is attached
+          FEATURE
+
+          define_steps do
+            When('some data is attached') do
+              attach("'\x00'attachement", 'text/x.cucumber.log+plain')
+            end
+          end
+
+          it 'does not report an error' do
+            expect(@out.string).not_to include 'Error'
+          end
+
+          it 'properly attaches the data' do
+            expect(@out.string).to include "'\x00'attachement"
+          end
+        end
+      end
     end
   end
 end