Skip to content

Commit

Permalink
Revert "Add support for message formatters with dry runs (#1537)" (#1539
Browse files Browse the repository at this point in the history
)

This reverts commit b691021.
  • Loading branch information
aurelien-reeves committed May 11, 2021
1 parent b691021 commit 9b6fcfb
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 19 deletions.
5 changes: 0 additions & 5 deletions CHANGELOG.md
Expand Up @@ -16,11 +16,6 @@ Please visit [cucumber/CONTRIBUTING.md](https://github.com/cucumber/cucumber/blo

### Fixed

- '--dry-run' now supports 'message' based-formatters
([1537](https://github.com/cucumber/cucumber-ruby/pull/1537)
[1496](https://github.com/cucumber/cucumber-ruby/issues/1496)
[1488](https://github.com/cucumber/cucumber-ruby/issues/1488)
[aurelien-reeves](https://github.com/aurelien-reeves))
- `attach` can now handle null bytes in the data.
([1536](https://github.com/cucumber/cucumber-ruby/pull/1536)
[1529](https://github.com/cucumber/cucumber-ruby/issues/1529)
Expand Down
13 changes: 0 additions & 13 deletions features/docs/cli/dry_run.feature
Expand Up @@ -26,19 +26,6 @@ Feature: Dry Run
"""

Scenario: With message formatter
Given a file named "features/test.feature" with:
"""
Feature: test
Scenario:
Given this step passes
"""
And the standard step definitions
When I run `cucumber --dry-run --publish-quiet --format message`
Then it should pass
And output should be valid NDJSON
And the output should contain NDJSON with key "status" and value "SKIPPED"

Scenario: In strict mode
Given a file named "features/test.feature" with:
"""
Expand Down
2 changes: 1 addition & 1 deletion lib/cucumber/runtime.rb
Expand Up @@ -233,14 +233,14 @@ def filters # rubocop:disable Metrics/AbcSize
filters << Filters::Randomizer.new(@configuration.seed) if @configuration.randomize?
# TODO: can we just use Glue::RegistryAndMore's step definitions directly?
step_match_search = StepMatchSearch.new(@support_code.registry.method(:step_matches), @configuration)
filters << Filters::BroadcastTestCaseReadyEvent.new(@configuration)
filters << Filters::ActivateSteps.new(step_match_search, @configuration)
@configuration.filters.each { |filter| filters << filter }
unless configuration.dry_run?
filters << Filters::ApplyAfterStepHooks.new(@support_code)
filters << Filters::ApplyBeforeHooks.new(@support_code)
filters << Filters::ApplyAfterHooks.new(@support_code)
filters << Filters::ApplyAroundHooks.new(@support_code)
filters << Filters::BroadcastTestCaseReadyEvent.new(@configuration)
filters << Filters::BroadcastTestRunStartedEvent.new(@configuration)
filters << Filters::Quit.new
filters << Filters::Retry.new(@configuration)
Expand Down

0 comments on commit 9b6fcfb

Please sign in to comment.