(snippet pattern) #331
Merged
(snippet pattern) #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Thank you for contribution. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Ruby snippet text generated by Cucumber causes Ruby warnings.
This pull request fixes that by wrapping the snippet pattern in parentheses.
To see the warning, run any file with Cucumber-generated snippet text (i.e.
foo.feature) withruby -cv foo.feature.Adding parentheses around the text generated by
RbModule#snippet_patternprevents these warnings from appearing. I've updated the specs to reflect this change. I've also created an issue which has more details and screenshots, as well as several comments.Thanks, and i'm open to feedback!
Martin