Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

History.md Update #1180

Merged
merged 2 commits into from
Aug 15, 2017
Merged

History.md Update #1180

merged 2 commits into from
Aug 15, 2017

Conversation

mxygem
Copy link
Member

@mxygem mxygem commented Aug 14, 2017

Summary

History.md update.

Details

  • 6 PRs
  • They're in numerical order too!

Motivation and Context

We need to keep track of what's changed!

How Has This Been Tested?

Code change is only to a .md file, but bundle exec rake is 馃憤

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update.

@mxygem
Copy link
Member Author

mxygem commented Aug 14, 2017

Waiting on Travis to finish before merging though there's no change to code. :p

* Add 1173
@mxygem mxygem merged commit 50a55c3 into cucumber:master Aug 15, 2017
@mxygem mxygem deleted the history_update branch August 15, 2017 00:35
@brasmusson
Copy link
Contributor

@mattwynne Don't you also think that a explicit note at the top of the History.md about the intended ordering of entries, both would help the readers, and us contributors?

I elaborated my personal preference in the_greenhouse slack forum.

@jaysonesmith I prefer a "latest change first" ordering, but I don't want to criticise you, it the support for contributors that is not as good as it should be.

@mattwynne
Copy link
Member

@mattwynne Don't you also think that a explicit note at the top of the History.md about the intended ordering of entries, both would help the readers, and us contributors?

Yes, though I'd prefer to advise people to use the script, which should do that consistently now.

@mxygem
Copy link
Member Author

mxygem commented Aug 15, 2017

@brasmusson That's easy enough to change moving forward! 馃憤

@lock
Copy link

lock bot commented Oct 24, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants