Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to use the gherkin step location in the Json formatter. #1243

Merged
merged 2 commits into from Jul 13, 2018

Conversation

brasmusson
Copy link
Contributor

Summary

Change to use the gherkin step location in the Json formatter.

Details

For test steps from scenario outlines use the line of the outline step instead of line of the example table row.

Motivation and Context

Fixes #1108 (a regression from v1.3.x).
Depends on cucumber/cucumber-ruby-core#150.

How Has This Been Tested?

The automated test suite has been updated to verify this behavior.

Types of changes

  • Refactor (code change that does not change external functionality)
  • Bug fix (non-breaking change which fixes an issue) - regression from v1.3.x
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I've added tests for my code
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@mjnohai
Copy link

mjnohai commented Feb 21, 2018

any progress on this?

@stale
Copy link

stale bot commented Apr 22, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs.

@stale stale bot added the ⌛ stale Will soon be closed by stalebot unless there is activity label Apr 22, 2018
@stale
Copy link

stale bot commented Apr 29, 2018

This issue has been automatically closed because of inactivity. You can support the Cucumber core team on opencollective.

@stale stale bot closed this Apr 29, 2018
@brasmusson brasmusson reopened this Jul 8, 2018
@stale stale bot removed the ⌛ stale Will soon be closed by stalebot unless there is activity label Jul 8, 2018
For test steps from scenario outlines use the line of the outline step
instead of line of the example table row.
@brasmusson brasmusson merged commit 03e8163 into master Jul 13, 2018
brasmusson added a commit that referenced this pull request Jul 13, 2018
@brasmusson brasmusson deleted the json-outline-step-fix branch July 13, 2018 13:11
@lock
Copy link

lock bot commented Jul 13, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSON formatter shows incorrect line number for steps in a Scenario Outline
2 participants