Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spike/altered loading strategy #1349

Merged
merged 11 commits into from Sep 19, 2019
Merged

Spike/altered loading strategy #1349

merged 11 commits into from Sep 19, 2019

Commits on Jun 5, 2019

  1. Spike - 2nd method to add to top level switch

    @luke-hill
    luke-hill committed Jun 5, 2019
    Copy the full SHA
    6f657b3 View commit details
    Browse the repository at this point in the history

  2. Switch config option dynamically at auto-load phase£

    @luke-hill
    luke-hill committed Jun 5, 2019
    Copy the full SHA
    31217c7 View commit details
    Browse the repository at this point in the history

  3. Tidy up around temp files and a spec in a related area

    @luke-hill
    luke-hill committed Jun 5, 2019
    Copy the full SHA
    df079b3 View commit details
    Browse the repository at this point in the history

  4. Add unit tests for new config functionality

    @luke-hill
    luke-hill committed Jun 5, 2019
    Copy the full SHA
    af0417b View commit details
    Browse the repository at this point in the history

  5. Changelog entry including blog link TBD

    @luke-hill
    luke-hill committed Jun 5, 2019
    Copy the full SHA
    58fb953 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2019

  1. Revert specs to use require as default rule, alter name of configurab… 

    …le parameter accordingly
    @luke-hill
    luke-hill committed Sep 13, 2019
    Copy the full SHA
    7daaf3f View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into spike/altered_loading_strategy

    @luke-hill
    luke-hill committed Sep 13, 2019
    Copy the full SHA
    f6e11ba View commit details
    Browse the repository at this point in the history

  3. Updated the changelog accordingly (Blog post still not yet published)

    @luke-hill
    luke-hill committed Sep 13, 2019
    Copy the full SHA
    efd028a View commit details
    Browse the repository at this point in the history

  4. As the logic has inverted, we also need to invert the specs!

    @luke-hill
    luke-hill committed Sep 13, 2019
    Copy the full SHA
    d30f598 View commit details
    Browse the repository at this point in the history

  5. Bugfix 

    Because all of the specs run inside a single ruby process/thread, the 'caching' state of load and require is done per test

In the previous iteration, we ran the caching test once(require) and the non-caching test twice(load)

Now we run the caching test twice, we need to ensure the names aren't identical to prevent test-leakage or pollution across tests
    @luke-hill
    luke-hill committed Sep 13, 2019
    Copy the full SHA
    ce13f21 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2019

  1. Alleviate failures when aruba tries to reload previously cached files… 

    … which have been overwritten mid-thread

To fix this we need to ensure each file is uniquely named (Or keep this config setting on.
    @luke-hill
    luke-hill committed Sep 17, 2019
    Copy the full SHA
    53817c2 View commit details
    Browse the repository at this point in the history