Skip to content

Commit

Permalink
Explicitly use Prawn 0.6.3 for pdf formatter since 0.7.1 is broken
Browse files Browse the repository at this point in the history
  • Loading branch information
aslakhellesoy committed Jan 17, 2010
1 parent 2d70244 commit 948f79f
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 8 deletions.
1 change: 1 addition & 0 deletions History.txt
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

=== Bugfixes
* Update --help for --tags which was out of date. (Aslak Hellesøy)
* Explicitly use Prawn 0.6.3 for pdf formatter since 0.7.1 is broken (Aslak Hellesøy)
* PDF formatter renders tables incorrectly (#553 Andy Waite)
* Better colouring in HTML report (Rob Aldred)
* Detect output encoding properly on JRuby+Windows (Aslak Hellesøy)
Expand Down
6 changes: 4 additions & 2 deletions Rakefile
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,10 @@ begin
gem.add_dependency 'json_pure', '>= 1.2.0'

gem.add_development_dependency 'nokogiri', '>= 1.4.1'
gem.add_development_dependency 'prawn', '>= 0.6.3'
gem.add_development_dependency 'rspec', '>= 1.2.9'
gem.add_development_dependency 'prawn', '= 0.6.3'
gem.add_development_dependency 'prawn-format', '= 0.2.3'
gem.add_development_dependency 'rspec', '>= 1.3.0'
gem.add_development_dependency 'syntax', '>= 1.0.0'
gem.add_development_dependency 'spork', '>= 0.7.5' unless Cucumber::JRUBY || Cucumber::WINDOWS

extend Cucumber::Formatter::ANSIColor
Expand Down
6 changes: 1 addition & 5 deletions features/support/env.rb
Original file line number Diff line number Diff line change
Expand Up @@ -95,11 +95,7 @@ def run(command)
end

def run_spork_in_background(port = nil)
begin
require 'spork'
rescue Gem::LoadError => ex
gem 'spork', '>= 0.7.5' # Ensure correct spork version number to avoid false-negatives.
end
require 'spork'

pid = fork
in_current_dir do
Expand Down
5 changes: 4 additions & 1 deletion lib/cucumber/formatter/pdf.rb
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,14 @@
require 'cucumber/formatter/io'
require 'fileutils'
begin
gem 'prawn', '=0.6.3'
require 'prawn'
require "prawn/layout"

gem 'prawn-format', '=0.2.3'
require "prawn/format"
rescue LoadError => e
e.message >> "\nPlease gem install prawn prawn-format"
e.message << "\nPlease gem install prawn --version 0.6.3 && gem install prawn-format --version 0.2.3"
raise e
end

Expand Down

0 comments on commit 948f79f

Please sign in to comment.