Pick up failure on after hook [#272 state:resolved]

History.txt

@@ -2,6 +2,7 @@
 
 === New features
 * New translation for Hungarian (#287 Bence Golda)
+* Pick up failure on after hook (#272 Aslak Hellesøy)
 
 === Bugfixes
 * Exceptions from steps called within hooks are now reraised. (#294 Ben Mabey)

Manifest.txt

@@ -195,6 +195,8 @@ examples/tickets/features/246.feature
 examples/tickets/features/248.feature
 examples/tickets/features/270/back.feature
 examples/tickets/features/270/back.steps.rb
+examples/tickets/features/272/hooks.feature
+examples/tickets/features/272/hooks_steps.rb
 examples/tickets/features/279/py_string_indent.feature
 examples/tickets/features/279/py_string_indent.steps.rb
 examples/tickets/features/279/wrong.feature_

examples/tickets/Rakefile

@@ -2,15 +2,15 @@ $:.unshift(File.dirname(__FILE__) + '/../../lib')
 require 'cucumber/rake/task'
 
 Cucumber::Rake::Task.new(:pretty) do |t|
-  t.cucumber_opts = "--format pretty -q"
+  t.cucumber_opts = "--tags ~@intentional_failure --format pretty -q"
 end
 
 Cucumber::Rake::Task.new(:html) do |t|
-  t.cucumber_opts = "--format html --out features.html"
+  t.cucumber_opts = "--tags ~@intentional_failure --format html --out features.html"
 end
 
 Cucumber::Rake::Task.new(:progress) do |t|
-  t.cucumber_opts = "--format progress -i -n"
+  t.cucumber_opts = "--tags ~@intentional_failure --format progress -i -n"
 end
 
 task :default => [:pretty, :html, :progress]

examples/tickets/features/272/hooks.feature

@@ -0,0 +1,26 @@
+@intentional_failure
+Feature: Hooks
+  In order to integrate with my complex environment
+  I need to check scenario status in an After block
+
+  @272_failed 
+  Scenario: Failed
+    Given I fail
+
+  @272_undefined
+  Scenario: Undefined
+    Given I am undefined
+
+  @272_passed
+  Scenario: Passed
+    Given I pass
+
+  @272_outline
+  Scenario Outline: Should work too
+    Given <something>
+
+    Examples:
+      | something      |
+      | I fail         |
+      | I am undefined |
+      | I pass         |

examples/tickets/features/272/hooks_steps.rb

@@ -0,0 +1,53 @@
+require 'spec/expectations'
+
+Given /^I fail$/ do
+  raise "BOOM (this is expected)"
+end
+
+Given /^I pass$/ do
+end
+
+module HookChecks
+  def check_failed(scenario)
+    scenario.should be_failed
+    scenario.should_not be_passed
+    scenario.exception.message.should == "BOOM (this is expected)"
+  end
+
+  def check_undefined(scenario)
+    scenario.should_not be_failed
+    scenario.should_not be_passed
+  end
+
+  def check_passed(scenario)
+    scenario.should_not be_failed
+    scenario.should be_passed
+  end
+end
+
+World(HookChecks)
+
+After('@272_failed') do |scenario|
+  check_failed(scenario)
+end
+
+After('@272_undefined') do |scenario|
+  check_undefined(scenario)
+end
+
+After('@272_passed') do |scenario|
+  check_passed(scenario)
+end
+
+counter = 0
+After('@272_outline') do |scenario|
+  case(counter)
+    when 0
+      check_failed(scenario)
+    when 1
+      check_undefined(scenario)
+    when 2
+      check_passed(scenario)
+  end
+  counter +=1
+end

lib/cucumber/ast/outline_table.rb

@@ -70,6 +70,16 @@ def accept_hook?(hook)
           @table.accept_hook?(hook)
         end
 
+        # Returns true if one or more steps failed
+        def failed?
+          @step_invocations.failed?
+        end
+
+        # Returns true if all steps passed
+        def passed?
+          @step_invocations.passed?
+        end
+
         private
 
         def header?

lib/cucumber/ast/scenario.rb

@@ -34,6 +34,21 @@ def accept(visitor)
         end
       end
 
+      # Returns true if one or more steps failed
+      def failed?
+        @steps.failed?
+      end
+
+      # Returns true if all steps passed
+      def passed?
+        @steps.passed?
+      end
+
+      # Returns the first exception (if any)
+      def exception
+        @steps.exception
+      end
+
       def skip_invoke!
         @steps.each{|step_invocation| step_invocation.skip_invoke!}
         @feature.next_feature_element(self) do |next_one|

lib/cucumber/ast/step_collection.rb

@@ -54,6 +54,14 @@ def exception
         @exception ||= ((failed = @steps.detect {|step| step.exception}) && failed.exception)
       end
 
+      def failed?
+        @steps.detect{|step_invocation| step_invocation.status == :failed}
+      end
+
+      def passed?
+        @steps.detect{|step_invocation| step_invocation.status != :passed}.nil?
+      end
+
       def to_sexp
         @steps.map{|step| step.to_sexp}
       end