-
-
Notifications
You must be signed in to change notification settings - Fork 695
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
emit readable, more concise /"(.*?)"/ rather than /"([^"]*)"/
I suggested this change while reviewing a cucumber-using project: - Given /^"([^"]*)" instance's provider is not accessible$/ do |arg1| + Given /^"(.*?)" instance's provider is not accessible$/ do |arg1| since the use of non-greedy .*? is equivalent and more readable. Then I learned that these were based on suggestions from cucumber, so now I'm suggesting the improvement here.
- Loading branch information
Jim Meyering
committed
Feb 27, 2012
1 parent
2ccea1e
commit af4625c
Showing
3 changed files
with
7 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters