gherkin-c does not build with MSVC

[DewJunkie]

Acceptance Criteria:

• gherkin-c can build with msvc

Summary

MSVC includes the library m.lib in the default CRT. Explicitly linking causes the build to fail.

Expected Behavior

gerkin-c builds successfully by following the build instructions in readme.md

Current Behavior

C:\dev\extern\cucumber\gherkin\c\out\build\x64-Debug (default)\LINK : fatal error LNK1104: cannot open file 'm.lib'

Possible Solution

Add check for existance of m.lib and if exists, then link it in

include(CheckLibraryExists)
CHECK_LIBRARY_EXISTS(m log10 "" HAVE_LIB_M)   
if (HAVE_LIB_M)  
    target_link_libraries(gherkin PRIVATE m)
endif (HAVE_LIB_M)

Context & Motivation

Support all the platforms

Your Environment

MSVC 16.8.442.31521

[DewJunkie]

Added PR 1199, maybe proper procedure is just to create a PR?

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs.

[stale]

This issue has been automatically closed because of inactivity. You can support the Cucumber core team on opencollective.