Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Language codes in gherkin-languages.json #1221

Closed
nvmkpk opened this issue Oct 20, 2020 · 3 comments · Fixed by #1238
Closed

Language codes in gherkin-languages.json #1221

nvmkpk opened this issue Oct 20, 2020 · 3 comments · Fixed by #1238
Labels
library: gherkin ⚡ enhancement Request for new functionality

Comments

@nvmkpk
Copy link
Contributor

nvmkpk commented Oct 20, 2020

Summary

It appears the language codes used in gherkin-languages.json file do not follow ISO language codes (ISO 639-X). Using the ISO language codes is more common in most software development. Any plans on changing the codes?
@aslakhellesoy
Copy link
Contributor

The gherkin-languages.json file uses ISO 639-1 and falls back to ISO 639-2 for languages that don't exist in ISO 639-1. One example is ast for Asturian.

Some codes, such as cy-GB might be wrong (I think that one should be cy (ISO 639-1) or cym (ISO 639-2).

What discrepancies have you found?

P.S. Some languages are unofficial/made-up/fun such as en-pirate and en-lol where we've made up codes.

@nvmkpk
Copy link
Contributor Author

nvmkpk commented Oct 20, 2020

One for sure is for Telugu. The ISO 639-1 code for it is te but the json file has it as tl.

@aslakhellesoy
Copy link
Contributor

Happy to take a pr for that

@aslakhellesoy aslakhellesoy added library: gherkin ⚡ enhancement Request for new functionality labels Nov 4, 2020
@nvmkpk nvmkpk mentioned this issue Nov 7, 2020
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
library: gherkin ⚡ enhancement Request for new functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixing ISO 639-1 code for Telugu language
2 participants
@aslakhellesoy @nvmkpk