Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gherkin java: Improved contributing documentation #314

Merged
merged 1 commit into from
Dec 6, 2017

Conversation

tsundberg
Copy link
Member

Summary

The CONTRIBUTING.md wasn't clear on how to contribute.

Details

I updated the reference to the CONTRIBUTING.md that was missing. It pointed towards an old file in cucumber/gherkin.

The repository to clone was cucumber/gherkin which is obsolete. I changed it to say cucumber/cucumber instead.

Motivation and Context

The documentation confused me when I wanted to share another pull request. I thought I better update the documentation when I noticed the problem.

How Has This Been Tested?

I have done manual testing to verify that the updated links ends up where I expected them to end up.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

  • I've added tests for my code.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@mpkorstanje mpkorstanje merged commit 32cb274 into master Dec 6, 2017
@mpkorstanje mpkorstanje deleted the clone-the-proper-repo-when-contributing branch December 6, 2017 20:38
@lock
Copy link

lock bot commented Dec 6, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants