Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: Link for Cucumber Expressions for Ruby is wrong #389

Closed
Donavan opened this issue May 18, 2018 · 5 comments
Closed

Documentation: Link for Cucumber Expressions for Ruby is wrong #389

Donavan opened this issue May 18, 2018 · 5 comments
Labels
📖 documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@Donavan
Copy link

Donavan commented May 18, 2018

The README.md for Cucumber expressions has a link for "The docs are here". This link points to http://docs.cucumber.io/cucumber-expressions/ however the correct link is http://docs.cucumber.io/cucumber/cucumber-expressions/

Since the readonly copy of this found at https://github.com/cucumber/cucumber-expressions-ruby is the number 1 link when you search for "cucumber expressions ruby" that should probably be updated.

@xtrasimplicity
Copy link
Member

xtrasimplicity commented May 18, 2018

Thanks @Donavan. If you have a few moments and are able to, it would be great if you could submit a PR on the subrepo.

If not, one of us will look into this when we get a moment.

Thanks again for reporting this! 👍

@xtrasimplicity
Copy link
Member

Thanks again @Donavan. All updated. :)

@xtrasimplicity
Copy link
Member

xtrasimplicity commented May 24, 2018

@aslakhellesoy It looks like your latest commits to cucumber/cucumber-expressions-ruby have overwritten my changes to the readme file here. I've made the change again - is there any chance we can keep it there? :)

Old commit
New commit

Edit: It looks like this may be due to it being a Read-only repository...

@aslakhellesoy
Copy link
Contributor

This issue was moved to cucumber/docs#196

@lock
Copy link

lock bot commented Jun 15, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
📖 documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants