gherkin js: fix ability to pass language to parser #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyleroush
approved these changes
Jun 5, 2018
|
@charlierudolph, the build system will now sync monorepo branches to subrepo branches (where they'll be built with Travis' matrix against multiple node versions). This sync will only happen if the branch name starts with the same name as the monorepo directory, in this case I'll merge this one anyway - thanks! |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cucumber/cucumber-js#1103 is failing because the feature was lost in 5.1.0. The feature was added in #288 but I edited the generated file instead of the razor file so it got reverted on a later build.
Noticed the js tests added in #288 weren't running on CI. By default, mocha does not recurse directories, so some tests were skipped when running make. Fix that and the code that would make it pass.