Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Italian translation for Rule keyword and for Feature synonym keywords #1318

Merged
merged 6 commits into from Jan 25, 2021

Conversation

mgiustiniani
Copy link
Contributor

Summary

Translated Keywords

Motivation and Context

Translations missing

How Has This Been Tested?

It hasn't.

Types of changes

  • Bug fix (non-breaking change which fixes an issue).

@mpkorstanje
Copy link
Contributor

@ehuelsmann ?

9 distributions installed
touch .cpanfile_dependencies
perl helper-scripts/build_languages.pl < gherkin-languages.json > lib/Gherkin/Generated/Languages.pm
Can't locate Cpanel/JSON/XS.pm in @INC (you may need to install the Cpanel::JSON::XS module) (@INC contains: /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.30.0 /usr/local/share/perl/5.30.0 /usr/lib/x86_64-linux-gnu/perl5/5.30 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.30 /usr/share/perl/5.30 /usr/local/lib/site_perl /usr/lib/x86_64-linux-gnu/perl-base) at helper-scripts/build_languages.pl line 6.

@ehuelsmann
Copy link
Contributor

@mpkorstanje: there's a fix for that in PR #1316. I was waiting to allow review on it, but since this change depends on it, I'll merge. It'll show correctness of the PR.

@mpkorstanje
Copy link
Contributor

mpkorstanje commented Jan 24, 2021

@mgiustiniani looks good. Please add an entry under the Fixed header at the top of the file and your name at the bottom of the file.

https://github.com/cucumber/cucumber/blob/master/gherkin/CHANGELOG.md

@mgiustiniani
Copy link
Contributor Author

hi @mpkorstanje, i added changelog info to PR

@mpkorstanje mpkorstanje merged commit 02d5480 into cucumber:master Jan 25, 2021
@aslakhellesoy
Copy link
Contributor

Hi @mgiustiniani,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

  • ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
  • 💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
  • 💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
  • ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
  • 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team,
Aslak Hellesøy
Creator of Cucumber

@mpkorstanje
Copy link
Contributor

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants