Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup gherkin dotnet #1511

Merged
merged 24 commits into from May 11, 2021
Merged

Cleanup gherkin dotnet #1511

merged 24 commits into from May 11, 2021

Conversation

gasparnagy
Copy link
Member

@gasparnagy gasparnagy commented May 3, 2021

Now this is done theoretically, but to make the build pass, we need to wait for a new version of the cucumber build docker image that is upgraded to use .NET 5.0.

The changes I did:

  • updated .NET Gherkin to use .NET 5.0 SDK for compilation (the target frameworks did not change)
  • fixed the .NET Gherkin tests and the parser to match the other gherkin implementation
  • included .NET Gherkin to the build
  • restructured the .NET Gherkin code to be better compatible with the messages structure (it does not use the real messages yet, but uses classes that are compatible to that)
  • fixed the .NET messages compilation for .NET 5 SDK, but did not make any other improvements there

@aurelien-reeves aurelien-reeves added 🏦 debt Tech debt language: c# 🔧 build Related to build / release process labels May 7, 2021
@aslakhellesoy
Copy link
Contributor

Great to see progress on this @gasparnagy!

Do you plan to migrate away from protobuf and use code generation from the JSON Schemas in this PR? If not, do you plan to do this in a different PR?

@gasparnagy
Copy link
Member Author

@aslakhellesoy that will be another PR. in this one i did not touch messages. .NET Gherkin did not have a reference to the messages so far, so I could do this fixes/cleanup without fixing messages first. But the structures that the improved Gherkin uses are essentially the same as we will have in messages generated from the schema (I manually copied the structure of the java generated classes for now).

@gasparnagy gasparnagy changed the title WIP: Cleanup gherkin dotnet Cleanup gherkin dotnet May 11, 2021
@gasparnagy gasparnagy marked this pull request as ready for review May 11, 2021 10:05
@aslakhellesoy
Copy link
Contributor

This looks good to me! Can we merge it?

@gasparnagy gasparnagy merged commit 8072d72 into master May 11, 2021
@gasparnagy gasparnagy deleted the cleanup-gherkin-dotnet branch May 11, 2021 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏦 debt Tech debt language: c# library: gherkin 🔧 build Related to build / release process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants