New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup gherkin dotnet #1511
Cleanup gherkin dotnet #1511
Conversation
Great to see progress on this @gasparnagy! Do you plan to migrate away from protobuf and use code generation from the JSON Schemas in this PR? If not, do you plan to do this in a different PR? |
@aslakhellesoy that will be another PR. in this one i did not touch messages. .NET Gherkin did not have a reference to the messages so far, so I could do this fixes/cleanup without fixing messages first. But the structures that the improved Gherkin uses are essentially the same as we will have in messages generated from the schema (I manually copied the structure of the java generated classes for now). |
This looks good to me! Can we merge it? |
Now this is done theoretically, but to make the build pass, we need to wait for a new version of the cucumber build docker image that is upgraded to use .NET 5.0.
The changes I did: