Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix CI process: rsync #402

Merged
merged 2 commits into from Jun 4, 2018
Merged

fix CI process: rsync #402

merged 2 commits into from Jun 4, 2018

Conversation

charlierudolph
Copy link
Member

resolves #343

Using BASH_SOURCE wasn't working when the shell wasn't bash.
Includes the additional change of syncing the gherkin changelog.

Makefile Outdated
@@ -1,3 +1,4 @@
SHELL := /bin/bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More portable: SHELL := /usr/bin/env bash. Can you change this please? (The other Makefiles do this).

@charlierudolph charlierudolph merged commit a62e0b6 into master Jun 4, 2018
@charlierudolph charlierudolph deleted the cr-fixRsync branch June 4, 2018 15:52
@lock
Copy link

lock bot commented Jun 4, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI hidden error in build
2 participants