Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Add step definitions #42

Open
wants to merge 3 commits into
from

Conversation

Projects
None yet
4 participants

Javix commented Jul 14, 2016

Adds step definitions sections extracted as suggested in #34

Owner

jbpros commented Jul 14, 2016

Thanks @Javix. I find this PR must easier to parse as it's focussed on a single topic and the updated table of content. Please keep doing that, that's really good :)

I think there is more to say about steps (what they represent, what do Given, When and Then mean, And and But, the sequential nature of steps, etc.) before introducing step definitions. That's why I think it would be better to keep the steps docs in the gherkin section. If you don't know what else to write about steps, I'd be happy to help you with that.

Could you move the steps section to gherkin.md and make a separate PR for the step definitions?

Javix commented Jul 15, 2016

@jbpros Thank you. As @aslakhellesoy already mentioned it in #34

Step definitions don't belong in this document. Please move to a separate step-definitions.md doc, in a separate PR.

I had to move the Step definitions section to a separate PR #42 . May be I misunderstood what exactly I had to move: Step definitions only or the entire Steps section including the Step definitions ? If so, I'll move Steps to back gherkinh.md, add the link to Step definitions which is already in a step_definitions.mdand in a separate PR #42 . Thank you.

@Javix Javix Add more description to Steps section
  * Add more details to Given, When,Then steps
  * Add And and But steps description
  * Add asterisk special character to use in steps
3ea7d80

Javix commented Jul 23, 2016 edited

I added more description to Given, When, Then steps, added the content for And and But steps as well as asterisk character. If the content is OK, I could move Steps section (only) to gherkin.md and keep only step definitions content here.

gavvvr commented Mar 9, 2017 edited

The info about asterisk-notation for step-definition shoud be moved to gherkin.md and merged asap. As a Cucumber user I had to ask on Stack Overflow to discover how else i can define steps besides using a set of reserved keywords.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment