Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add step definitions #42

Closed
wants to merge 3 commits into from
Closed

Add step definitions #42

wants to merge 3 commits into from

Conversation

belgoros
Copy link

Adds step definitions sections extracted as suggested in #34

@jbpros
Copy link
Member

jbpros commented Jul 14, 2016

Thanks @javix. I find this PR must easier to parse as it's focussed on a single topic and the updated table of content. Please keep doing that, that's really good :)

I think there is more to say about steps (what they represent, what do Given, When and Then mean, And and But, the sequential nature of steps, etc.) before introducing step definitions. That's why I think it would be better to keep the steps docs in the gherkin section. If you don't know what else to write about steps, I'd be happy to help you with that.

Could you move the steps section to gherkin.md and make a separate PR for the step definitions?

@belgoros
Copy link
Author

@jbpros Thank you. As @aslakhellesoy already mentioned it in #34

Step definitions don't belong in this document. Please move to a separate step-definitions.md doc, in a separate PR.

I had to move the Step definitions section to a separate PR #42 . May be I misunderstood what exactly I had to move: Step definitions only or the entire Steps section including the Step definitions ? If so, I'll move Steps to back gherkinh.md, add the link to Step definitions which is already in a step_definitions.mdand in a separate PR #42 . Thank you.

  * Add more details to Given, When,Then steps
  * Add And and But steps description
  * Add asterisk special character to use in steps
@belgoros
Copy link
Author

belgoros commented Jul 23, 2016

I added more description to Given, When, Then steps, added the content for And and But steps as well as asterisk character. If the content is OK, I could move Steps section (only) to gherkin.md and keep only step definitions content here.

@gavvvr
Copy link

gavvvr commented Mar 9, 2017

The info about asterisk-notation for step-definition shoud be moved to gherkin.md and merged asap. As a Cucumber user I had to ask on Stack Overflow to discover how else i can define steps besides using a set of reserved keywords.

@stale
Copy link

stale bot commented Nov 8, 2017

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs.

@stale stale bot added the ⌛ stale Will soon be closed by stalebot unless there is activity label Nov 8, 2017
@stale
Copy link

stale bot commented Nov 15, 2017

This issue has been automatically closed because of inactivity. You can support the Cucumber core team on opencollective.

@stale stale bot closed this Nov 15, 2017
@lock
Copy link

lock bot commented Nov 15, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Nov 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
📖 documentation Improvements or additions to documentation ⌛ stale Will soon be closed by stalebot unless there is activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants