Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR cucumber/cucumber#234 : Gitbook link and article on cucumber-rails #34

Closed
1 task done
mlvandijk opened this issue Sep 30, 2017 · 9 comments · Fixed by #194
Closed
1 task done

PR cucumber/cucumber#234 : Gitbook link and article on cucumber-rails #34

mlvandijk opened this issue Sep 30, 2017 · 9 comments · Fixed by #194
Labels
📖 documentation Improvements or additions to documentation good first issue Good for newcomers 🙏 help wanted Help wanted - not prioritized by core team ⚡ enhancement Request for new functionality

Comments

@mlvandijk
Copy link
Member

mlvandijk commented Sep 30, 2017

Update:

Inspired by #33, I had a look at open PR's in http://github.com/cucumber/cucumber
I've closed a few that were outdated, but there are several others we should look at.
(PR's are labelled 'type: docs'.)

@mlvandijk
Copy link
Member Author

Details:

@plaindocs
Copy link
Contributor

plaindocs commented Oct 10, 2017

Not yet done:

I'd be tempted to ignore these four, unless someone tells me it is all AWESOME stuff

Added in #39

Not really relevant:

@mlvandijk
Copy link
Member Author

mlvandijk commented Oct 11, 2017

Info on BDD and TDD might be good (possibly an external link, or the blog by Seb Rose: https://cucumber.io/blog/2017/05/15/intro-to-bdd-and-tdd)
Having our own info about BDD might be better than a link to wikipedia, as proposed here: cucumber/common#283 as we would have more control over it. The blog is also good.

@vcavallo
Copy link
Contributor

I've given a round of review on cucumber/common#50 (review) which @plaindocs mentioned wasn't ready above.

@mlvandijk mlvandijk added good first issue Good for newcomers and removed newcomers labels Oct 14, 2017
@mlvandijk
Copy link
Member Author

mlvandijk commented Oct 28, 2017

Update:

@olleolleolle
Copy link
Contributor

@mlvandijk I'll add that article as a PR to this project.

@mlvandijk
Copy link
Member Author

Had a look at the 4 PR's and used what I thought might be relevant. Updated in @plaindocs comment above.

@mlvandijk mlvandijk added the 📖 documentation Improvements or additions to documentation label Dec 8, 2017
@mlvandijk mlvandijk added the 🙏 help wanted Help wanted - not prioritized by core team label Dec 16, 2017
@mlvandijk mlvandijk added the Ruby label Dec 27, 2017
@mlvandijk
Copy link
Member Author

@aslakhellesoy see if cucumber/common#234 still relevant and merge it here? otherwise close

@mlvandijk mlvandijk changed the title Import any useful changes from old PRs on http://github.com/cucumber/cucumber PR cucumber/cucumber#234 : Gitbook link and article on cucumber-rails Mar 6, 2018
@mlvandijk mlvandijk added the ⚡ enhancement Request for new functionality label Mar 7, 2018
@mlvandijk
Copy link
Member Author

@olleolleolle If this should still be added, could you please do so? Otherwise, could we close this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📖 documentation Improvements or additions to documentation good first issue Good for newcomers 🙏 help wanted Help wanted - not prioritized by core team ⚡ enhancement Request for new functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants