Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallel execution with surefire and failsafe doesn't work with junit-vintage-engine #627

Open
martinschneider opened this issue Jun 6, 2021 · 1 comment

Comments

@martinschneider
Copy link

martinschneider commented Jun 6, 2021

Describe the bug
Parallel execution doesn't work with junit-vintage-engine. I looked into it and it appears to be an issue with surefire and failsafe rather than Cucumber. However, maybe we could clarify this in the documentation.

To Reproduce
See https://issues.apache.org/jira/browse/SUREFIRE-1918.

Expected behavior
Tests being executed in parallel.

Context & Motivation
Parallel execution is a critical feature for many Cucumber users. I want to use JUnit 5 assertions and Cucumber. This works by adding junit-vintage-engine as a runtime dependency. However, this breaks parallel execution of tests with both surefire and failsafe.
From what I can tell this is a bug in surefire (or just a scenario that's not supported) but I think we could update the documentation to highlight that this will not work with JUnit5. Unless, of course, there is a workaround I'm missing.

Screenshots
If applicable, add screenshots to help explain your problem.

Your Environment

  • Versions used: 6.10.4
  • Operating System and version: Ubuntu 20.04.2 LTS
  • Build tool: Apache Maven 3.8.1

Additional context
Add any other context about the problem here.
https://issues.apache.org/jira/browse/SUREFIRE-1918

@mpkorstanje mpkorstanje transferred this issue from cucumber/cucumber-jvm Jun 6, 2021
@mpkorstanje
Copy link
Contributor

mpkorstanje commented Jun 6, 2021

You may want to look at junit-team/junit5#2449. Or rather then using cucumber-junit and junit-vintage you can use cucumber-junit-platform-engine which does support parallel execution of scenarios. However until junit-team/junit5#2416 and junit-team/junit5#2623 are generally available JUnit 5 is not a feature complete replacemen for JUnit 4 so I'd forgo mentioning it in the general documentation.

What would be improved currently however is the explicit mention of JUnit 4 in the docs rather then JUnit in general.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants