Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build gherkin/dart #24

Closed
aslakhellesoy opened this issue Aug 11, 2021 · 5 comments
Closed

Build gherkin/dart #24

aslakhellesoy opened this issue Aug 11, 2021 · 5 comments

Comments

@aslakhellesoy
Copy link
Contributor

The new gherkin/dart module is not built in CI.

When cucumber/common#1630 was merged we forgot to add a job to .circleci/config.yml, so it isn't built as a separate job. There is nothing in gherkin/Makefile either, so the module isn't built as part of the serial job either.

/cc @mattwynne @aurelien-reeves

@mattwynne
Copy link
Member

Oops. I figured the fact that the CI was failing before we added Dart to the build image meant it was being tested in CI. I should have looked closer.

@lamkr are you interested in helping with this? It would be good to see how easy the CI / Make infrastructure is to understand for someone new to it.

@lamkr
Copy link
Contributor

lamkr commented Aug 13, 2021

Oops. I figured the fact that the CI was failing before we added Dart to the build image meant it was being tested in CI. I should have looked closer.

@lamkr are you interested in helping with this? It would be good to see how easy the CI / Make infrastructure is to understand for someone new to it.

hi, @mattwynne ! I don't have that much time available but I will do my best to help. I'm not an expert in CI either, but where can I start?

@mattwynne
Copy link
Member

@lamkr I think the place to start is to add a gherkin/dart/Makefile with a default target that compiles and tests the code. Then we can integrate that into the main gherkin/Makefile and finally add a job to CI to run it.

@ciaranmcnulty it strikes me this could present a good opportunity to try our ideas about breaking up the Docker image monolith, since the Makefile here is essentially green field?

@mattwynne
Copy link
Member

I've realised that the dart command wasn't even in the PATH in the build image, because I hadn't tested the installation script properly. I'll release a new version of the build image soon.

See cucumber/build#53

@mpkorstanje mpkorstanje transferred this issue from cucumber/common Nov 8, 2022
@mpkorstanje
Copy link
Contributor

Resolved by #3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants