-
-
Notifications
You must be signed in to change notification settings - Fork 698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gherkin-dart: initial commit #1630
Conversation
Hi @lamkr this is awesome! 🎉 thankyou so much! 🦄 🌈 ❤️ 💐 In terms of the build failures, I think it's down to us not yet having Dart on our build container. Can you give me a bit of guidance as to what we need to add to that docker image so the new dart stuff will build? |
If you want to chat 🍵 about this, you're welcome to join us in our community Slack in the #committers channel 😄 I'm also trying to make myself available for live pairing ⚡ you can book a slot with me here. |
Hello, @mattwynne ! Thank you by your help and sorry for the delay in my reply!
|
Thanks @lamkr. I tried it out locally on my M1 Mac and I had some problems. See cucumber/build#36 I think it might be due to me having an arm64 architecture machine. Let's discuss it over there. |
OK! Dart is now in v6.0.0 of the build image. The robots have already created #1678 which upgrades the |
@lamkr could you rebase this so we can get it merged in? |
# Conflicts: # package-lock.json # package.json
fix: Parser fix: add testdata files
Hi @lamkr, Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾 In return for this generous offer we hope you will:
On behalf of the Cucumber core team, |
Summary
Implemented Gherkin in Dart language.
Details
The Gherkin project was ported to the Dart language.
Motivation and Context
I really like the Cucumber tool and I'm in love with Dart. Then I decided to combine the useful with the pleasant by implementing the tool in the language.
How was this tested?
I ported all tests in Java to the Dart project.
I used Windows 10 Pro during implementation, and Dart 2.13.3 (stable) version.
The change does not affect other areas of the code.
Screenshots (if appropriate):
Types of changes
Checklist: