Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gherkin-dart: initial commit #1630

Merged
merged 11 commits into from
Aug 6, 2021
Merged

gherkin-dart: initial commit #1630

merged 11 commits into from
Aug 6, 2021

Conversation

lamkr
Copy link
Contributor

@lamkr lamkr commented Jun 23, 2021

Summary

Implemented Gherkin in Dart language.

Details

The Gherkin project was ported to the Dart language.

Motivation and Context

I really like the Cucumber tool and I'm in love with Dart. Then I decided to combine the useful with the pleasant by implementing the tool in the language.

How was this tested?

I ported all tests in Java to the Dart project.
I used Windows 10 Pro during implementation, and Dart 2.13.3 (stable) version.
The change does not affect other areas of the code.

Screenshots (if appropriate):

Types of changes

  • [] Bug fix (uninterrupted change that fixes a problem).
  • New feature (uninterrupted change that adds functionality).
  • [] Decisive change (fix or feature that would cause existing functionality not to work as expected).

Checklist:

  • [] Change has been ported to Java.
  • [] Change has been ported to Ruby.
  • [] Change has been ported to JavaScript.
  • [] Change has been moved to Go.
  • [] Change has been ported to .NET.
  • I added tests to my code.
  • My change requires a change to the documentation.
  • I updated the documentation accordingly.
  • [] I updated CHANGELOG accordingly.

@mattwynne
Copy link
Member

Hi @lamkr this is awesome! 🎉 thankyou so much! 🦄 🌈 ❤️ 💐

In terms of the build failures, I think it's down to us not yet having Dart on our build container.

Can you give me a bit of guidance as to what we need to add to that docker image so the new dart stuff will build?

@mattwynne
Copy link
Member

If you want to chat 🍵 about this, you're welcome to join us in our community Slack in the #committers channel 😄

I'm also trying to make myself available for live pairing ⚡ you can book a slot with me here.

@aurelien-reeves aurelien-reeves added the ⚡ enhancement Request for new functionality label Jun 28, 2021
@lamkr
Copy link
Contributor Author

lamkr commented Jul 6, 2021

Hello, @mattwynne ! Thank you by your help and sorry for the delay in my reply!
I tested the commands below here on my machine and they worked. For us to be sure, could you test it there too, please?

# Install Dart
ENV DART_SDK /usr/lib/dart
RUN apt-get install apt-transport-https
RUN sh -c 'curl -s -L https://dl-ssl.google.com/linux/linux_signing_key.pub | apt-key add -'
RUN sh -c 'curl -s -L https://storage.googleapis.com/download.dartlang.org/linux/debian/dart_stable.list \ 
	-o /etc/apt/sources.list.d/dart_stable.list'
RUN apt-get update
RUN apt-get install dart
ENV PATH $DART_SDK/bin:$PATH

@mattwynne mattwynne mentioned this pull request Jul 6, 2021
@mattwynne
Copy link
Member

Thanks @lamkr. I tried it out locally on my M1 Mac and I had some problems. See cucumber/build#36

I think it might be due to me having an arm64 architecture machine. Let's discuss it over there.

@mattwynne
Copy link
Member

OK! Dart is now in v6.0.0 of the build image.

The robots have already created #1678 which upgrades the main branch to use the new build image. If that passes, we can merge it, rebase this branch and it should then be running with Dart in the build image.

@mattwynne
Copy link
Member

@lamkr could you rebase this so we can get it merged in?

@mattwynne mattwynne merged commit 7a5d7cd into cucumber:main Aug 6, 2021
@aslakhellesoy
Copy link
Contributor

Hi @lamkr,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

  • ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
  • 💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
  • 💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
  • ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
  • 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team,
Aslak Hellesøy
Creator of Cucumber

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚡ enhancement Request for new functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants