Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide trailing space in Irish keywords #243

Merged
merged 3 commits into from
Apr 11, 2024
Merged

Provide trailing space in Irish keywords #243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6612402
Missing trailing space in Irish keywords
kieran-ryan Apr 10, 2024
af1d42f
Changelog trailing space in Irish keywords
kieran-ryan Apr 10, 2024
fda1198
Changelog for tamil 'and' and 'but' fix
kieran-ryan Apr 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ This project adheres to [Semantic Versioning](http://semver.org).
This document is formatted according to the principles of [Keep A CHANGELOG](http://keepachangelog.com).

## [Unreleased]
### Fixed
- Provide trailing space in Irish keywords ([#243](https://github.com/cucumber/gherkin/pull/243))
- Tamil "And" and "But" translations should have single trailing space ([#243](https://github.com/cucumber/gherkin/pull/243))

## [28.0.0] - 2024-02-15
### Added
Expand Down
14 changes: 7 additions & 7 deletions c/src/dialect.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1410,13 +1410,13 @@ static const Dialect fr_dialect = {
&fr_then_keywords,
&fr_when_keywords };

static const wchar_t* const ga_and_KEYWORDS[] = { L"* ", L"Agus" };
static const wchar_t* const ga_and_KEYWORDS[] = { L"* ", L"Agus " };
static const Keywords ga_and_keywords = { 2, ga_and_KEYWORDS };

static const wchar_t* const ga_background_KEYWORDS[] = { L"Cúlra" };
static const Keywords ga_background_keywords = { 1, ga_background_KEYWORDS };

static const wchar_t* const ga_but_KEYWORDS[] = { L"* ", L"Ach" };
static const wchar_t* const ga_but_KEYWORDS[] = { L"* ", L"Ach " };
static const Keywords ga_but_keywords = { 2, ga_but_KEYWORDS };

static const wchar_t* const ga_examples_KEYWORDS[] = { L"Samplaí" };
Expand All @@ -1425,7 +1425,7 @@ static const Keywords ga_examples_keywords = { 1, ga_examples_KEYWORDS };
static const wchar_t* const ga_feature_KEYWORDS[] = { L"Gné" };
static const Keywords ga_feature_keywords = { 1, ga_feature_KEYWORDS };

static const wchar_t* const ga_given_KEYWORDS[] = { L"* ", L"Cuir i gcás go", L"Cuir i gcás nach", L"Cuir i gcás gur", L"Cuir i gcás nár" };
static const wchar_t* const ga_given_KEYWORDS[] = { L"* ", L"Cuir i gcás go ", L"Cuir i gcás nach ", L"Cuir i gcás gur ", L"Cuir i gcás nár " };
static const Keywords ga_given_keywords = { 5, ga_given_KEYWORDS };

static const wchar_t* const ga_rule_KEYWORDS[] = { L"Riail" };
Expand All @@ -1437,10 +1437,10 @@ static const Keywords ga_scenario_keywords = { 2, ga_scenario_KEYWORDS };
static const wchar_t* const ga_scenarioOutline_KEYWORDS[] = { L"Cás Achomair" };
static const Keywords ga_scenarioOutline_keywords = { 1, ga_scenarioOutline_KEYWORDS };

static const wchar_t* const ga_then_KEYWORDS[] = { L"* ", L"Ansin" };
static const wchar_t* const ga_then_KEYWORDS[] = { L"* ", L"Ansin " };
static const Keywords ga_then_keywords = { 2, ga_then_KEYWORDS };

static const wchar_t* const ga_when_KEYWORDS[] = { L"* ", L"Nuair a", L"Nuair nach", L"Nuair ba", L"Nuair nár" };
static const wchar_t* const ga_when_KEYWORDS[] = { L"* ", L"Nuair a ", L"Nuair nach ", L"Nuair ba ", L"Nuair nár " };
static const Keywords ga_when_keywords = { 5, ga_when_KEYWORDS };

static const Dialect ga_dialect = {
Expand Down Expand Up @@ -3055,13 +3055,13 @@ static const Dialect sv_dialect = {
&sv_then_keywords,
&sv_when_keywords };

static const wchar_t* const ta_and_KEYWORDS[] = { L"* ", L"மேலும் ", L"மற்றும் " };
static const wchar_t* const ta_and_KEYWORDS[] = { L"* ", L"மேலும் ", L"மற்றும் " };
static const Keywords ta_and_keywords = { 3, ta_and_KEYWORDS };

static const wchar_t* const ta_background_KEYWORDS[] = { L"பின்னணி" };
static const Keywords ta_background_keywords = { 1, ta_background_KEYWORDS };

static const wchar_t* const ta_but_KEYWORDS[] = { L"* ", L"ஆனால் " };
static const wchar_t* const ta_but_KEYWORDS[] = { L"* ", L"ஆனால் " };
static const Keywords ta_but_keywords = { 2, ta_but_KEYWORDS };

static const wchar_t* const ta_examples_KEYWORDS[] = { L"எடுத்துக்காட்டுகள்", L"காட்சிகள்", L"நிலைமைகளில்" };
Expand Down
40 changes: 28 additions & 12 deletions cpp/src/lib/gherkin/cucumber/gherkin/dialect.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ all_keywords()
{ "examples", { "Eksempler" } },
{ "feature", { "Egenskab" } },
{ "given", { "* ", "Givet " } },
{ "rule", { "Rule" } },
{ "rule", { "Regel" } },
{ "scenario", { "Eksempel", "Scenarie" } },
{ "scenarioOutline", { "Abstrakt Scenario" } },
{ "then", { "* ", "Så " } },
Expand Down Expand Up @@ -399,7 +399,7 @@ all_keywords()
{ "examples", { "Ekzemploj" } },
{ "feature", { "Trajto" } },
{ "given", { "* ", "Donitaĵo ", "Komence " } },
{ "rule", { "Rule" } },
{ "rule", { "Regulo" } },
{ "scenario", { "Ekzemplo", "Scenaro", "Kazo" } },
{ "scenarioOutline", { "Konturo de la scenaro", "Skizo", "Kazo-skizo" } },
{ "then", { "* ", "Do " } },
Expand Down Expand Up @@ -489,17 +489,17 @@ all_keywords()
{
"ga",
{
{ "and", { "* ", "Agus" } },
{ "and", { "* ", "Agus " } },
{ "background", { "Cúlra" } },
{ "but", { "* ", "Ach" } },
{ "but", { "* ", "Ach " } },
{ "examples", { "Samplaí" } },
{ "feature", { "Gné" } },
{ "given", { "* ", "Cuir i gcás go", "Cuir i gcás nach", "Cuir i gcás gur", "Cuir i gcás nár" } },
{ "given", { "* ", "Cuir i gcás go ", "Cuir i gcás nach ", "Cuir i gcás gur ", "Cuir i gcás nár " } },
{ "rule", { "Riail" } },
{ "scenario", { "Sampla", "Cás" } },
{ "scenarioOutline", { "Cás Achomair" } },
{ "then", { "* ", "Ansin" } },
{ "when", { "* ", "Nuair a", "Nuair nach", "Nuair ba", "Nuair nár" } }
{ "then", { "* ", "Ansin " } },
{ "when", { "* ", "Nuair a ", "Nuair nach ", "Nuair ba ", "Nuair nár " } }
}
},
{
Expand Down Expand Up @@ -649,7 +649,7 @@ all_keywords()
{
"it",
{
{ "and", { "* ", "E " } },
{ "and", { "* ", "E ", "Ed " } },
{ "background", { "Contesto" } },
{ "but", { "* ", "Ma " } },
{ "examples", { "Esempi" } },
Expand Down Expand Up @@ -863,7 +863,7 @@ all_keywords()
{ "examples", { "Voorbeelden" } },
{ "feature", { "Functionaliteit" } },
{ "given", { "* ", "Gegeven ", "Stel " } },
{ "rule", { "Rule" } },
{ "rule", { "Regel" } },
{ "scenario", { "Voorbeeld", "Scenario" } },
{ "scenarioOutline", { "Abstract Scenario" } },
{ "then", { "* ", "Dan " } },
Expand Down Expand Up @@ -1049,9 +1049,9 @@ all_keywords()
{
"ta",
{
{ "and", { "* ", "மேலும் ", "மற்றும் " } },
{ "and", { "* ", "மேலும் ", "மற்றும் " } },
{ "background", { "பின்னணி" } },
{ "but", { "* ", "ஆனால் " } },
{ "but", { "* ", "ஆனால் " } },
{ "examples", { "எடுத்துக்காட்டுகள்", "காட்சிகள்", "நிலைமைகளில்" } },
{ "feature", { "அம்சம்", "வணிக தேவை", "திறன்" } },
{ "given", { "* ", "கொடுக்கப்பட்ட " } },
Expand Down Expand Up @@ -1199,7 +1199,7 @@ all_keywords()
{ "examples", { "Dữ liệu" } },
{ "feature", { "Tính năng" } },
{ "given", { "* ", "Biết ", "Cho " } },
{ "rule", { "Rule" } },
{ "rule", { "Quy tắc" } },
{ "scenario", { "Tình huống", "Kịch bản" } },
{ "scenarioOutline", { "Khung tình huống", "Khung kịch bản" } },
{ "then", { "* ", "Thì " } },
Expand All @@ -1222,6 +1222,22 @@ all_keywords()
{ "when", { "* ", "当" } }
}
},
{
"ml",
{
{ "and", { "* ", "ഒപ്പം" } },
{ "background", { "പശ്ചാത്തലം" } },
{ "but", { "* ", "പക്ഷേ" } },
{ "examples", { "ഉദാഹരണങ്ങൾ" } },
{ "feature", { "സവിശേഷത" } },
{ "given", { "* ", "നൽകിയത്" } },
{ "rule", { "നിയമം" } },
{ "scenario", { "രംഗം" } },
{ "scenarioOutline", { "സാഹചര്യത്തിന്റെ രൂപരേഖ" } },
{ "then", { "* ", "പിന്നെ" } },
{ "when", { "എപ്പോൾ" } }
}
},
{
"zh-TW",
{
Expand Down
28 changes: 14 additions & 14 deletions dart/assets/gherkin-languages.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,7 +278,7 @@
"Nə vaxt ki "
]
},
"be": {
"be": {
"and": [
"* ",
"I ",
Expand Down Expand Up @@ -1401,14 +1401,14 @@
"ga": {
"and": [
"* ",
"Agus"
"Agus "
],
"background": [
"Cúlra"
],
"but": [
"* ",
"Ach"
"Ach "
],
"examples": [
"Samplaí"
Expand All @@ -1418,10 +1418,10 @@
],
"given": [
"* ",
"Cuir i gcás go",
"Cuir i gcás nach",
"Cuir i gcás gur",
"Cuir i gcás nár"
"Cuir i gcás go ",
"Cuir i gcás nach ",
"Cuir i gcás gur ",
"Cuir i gcás nár "
],
"name": "Irish",
"native": "Gaeilge",
Expand All @@ -1437,14 +1437,14 @@
],
"then": [
"* ",
"Ansin"
"Ansin "
],
"when": [
"* ",
"Nuair a",
"Nuair nach",
"Nuair ba",
"Nuair nár"
"Nuair a ",
"Nuair nach ",
"Nuair ba ",
"Nuair nár "
]
},
"gj": {
Expand Down Expand Up @@ -3134,15 +3134,15 @@
"ta": {
"and": [
"* ",
"மேலும் ",
"மேலும் ",
"மற்றும் "
],
"background": [
"பின்னணி"
],
"but": [
"* ",
"ஆனால் "
"ஆனால் "
],
"examples": [
"எடுத்துக்காட்டுகள்",
Expand Down
28 changes: 14 additions & 14 deletions dotnet/Gherkin/gherkin-languages.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,7 +278,7 @@
"Nə vaxt ki "
]
},
"be": {
"be": {
"and": [
"* ",
"I ",
Expand Down Expand Up @@ -1401,14 +1401,14 @@
"ga": {
"and": [
"* ",
"Agus"
"Agus "
],
"background": [
"Cúlra"
],
"but": [
"* ",
"Ach"
"Ach "
],
"examples": [
"Samplaí"
Expand All @@ -1418,10 +1418,10 @@
],
"given": [
"* ",
"Cuir i gcás go",
"Cuir i gcás nach",
"Cuir i gcás gur",
"Cuir i gcás nár"
"Cuir i gcás go ",
"Cuir i gcás nach ",
"Cuir i gcás gur ",
"Cuir i gcás nár "
],
"name": "Irish",
"native": "Gaeilge",
Expand All @@ -1437,14 +1437,14 @@
],
"then": [
"* ",
"Ansin"
"Ansin "
],
"when": [
"* ",
"Nuair a",
"Nuair nach",
"Nuair ba",
"Nuair nár"
"Nuair a ",
"Nuair nach ",
"Nuair ba ",
"Nuair nár "
]
},
"gj": {
Expand Down Expand Up @@ -3134,15 +3134,15 @@
"ta": {
"and": [
"* ",
"மேலும் ",
"மேலும் ",
"மற்றும் "
],
"background": [
"பின்னணி"
],
"but": [
"* ",
"ஆனால் "
"ஆனால் "
],
"examples": [
"எடுத்துக்காட்டுகள்",
Expand Down