-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use multiple formatters in the same test run #392
Conversation
Codecov Report
@@ Coverage Diff @@
## main #392 +/- ##
==========================================
+ Coverage 81.13% 81.27% +0.14%
==========================================
Files 25 26 +1
Lines 1998 2024 +26
==========================================
+ Hits 1621 1645 +24
- Misses 274 275 +1
- Partials 103 104 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I'm looking forward to have it. Very nice.
I'm not very familiar with the Godog codebase (but I am familiar with Go and the Cucumber libraries it builds upon). The code looks good to me, but it's usually @lonnblad who reviews and merges pull requests in Godog. Let's wait a week or so to see if he has time to review this. |
This looks good to me, and if you think it's ready to merge I'll do it @vearutop. We're discussing a merge of godog/gobdd over in the #committers-go channel in the Cucumber slack - any chance you could join the discussion there? |
Hi @vearutop, Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾 In return for this generous offer we hope you will:
On behalf of the Cucumber core team, |
Resolves #346.
This PR implements formatter that can propagate events to multiple other formatters.
Multiple formatters can be configured as comma-separated list in
Options.Format
, for examplepretty,junit:junit.xml
.