Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use multiple formatters in the same test run #392

Merged
merged 2 commits into from
Jul 7, 2021

Conversation

vearutop
Copy link
Member

Resolves #346.

This PR implements formatter that can propagate events to multiple other formatters.
Multiple formatters can be configured as comma-separated list in Options.Format, for example pretty,junit:junit.xml.

@codecov
Copy link

codecov bot commented May 30, 2021

Codecov Report

Merging #392 (707025d) into main (60e2e2f) will increase coverage by 0.14%.
The diff coverage is 96.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #392      +/-   ##
==========================================
+ Coverage   81.13%   81.27%   +0.14%     
==========================================
  Files          25       26       +1     
  Lines        1998     2024      +26     
==========================================
+ Hits         1621     1645      +24     
- Misses        274      275       +1     
- Partials      103      104       +1     
Impacted Files Coverage Δ
internal/formatters/fmt_multi.go 91.66% <91.66%> (ø)
run.go 83.46% <100.00%> (+0.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60e2e2f...707025d. Read the comment docs.

@vearutop vearutop marked this pull request as ready for review May 30, 2021 20:35
Copy link

@voiski voiski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'm looking forward to have it. Very nice.

@aslakhellesoy
Copy link
Contributor

I'm not very familiar with the Godog codebase (but I am familiar with Go and the Cucumber libraries it builds upon).

The code looks good to me, but it's usually @lonnblad who reviews and merges pull requests in Godog. Let's wait a week or so to see if he has time to review this.

@aslakhellesoy
Copy link
Contributor

This looks good to me, and if you think it's ready to merge I'll do it @vearutop.

We're discussing a merge of godog/gobdd over in the #committers-go channel in the Cucumber slack - any chance you could join the discussion there?

@aslakhellesoy aslakhellesoy merged commit 7cadaef into cucumber:main Jul 7, 2021
@aslakhellesoy
Copy link
Contributor

Hi @vearutop,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

  • ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
  • 💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
  • 💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
  • ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
  • 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team,
Aslak Hellesøy
Creator of Cucumber

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use multiple formatters in the same test run
3 participants