Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include value from Exception.stacktrace if available #30

Merged
merged 1 commit into from
Mar 23, 2024

Conversation

mpkorstanje
Copy link
Contributor

@mpkorstanje mpkorstanje commented Mar 23, 2024

🤔 What's changed?

Include value from Exception.stacktrace if available. Fall back to the message otherwise.

This does require v24 of the messages in which the stacktrace was added.

⚡️ What's your motivation?

Closes: #26

🏷️ What kind of change is this?

  • ⚡ New feature (non-breaking change which adds new behaviour)

♻️ Anything particular you want feedback on?

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

@mpkorstanje mpkorstanje marked this pull request as ready for review March 23, 2024 18:15
@mpkorstanje mpkorstanje merged commit 3ede278 into main Mar 23, 2024
3 checks passed
@mpkorstanje mpkorstanje deleted the include-stack-trace branch March 23, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Exception.stackTrace
1 participant