Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix concat #126

Merged
merged 4 commits into from Mar 8, 2023
Merged

Fix concat #126

merged 4 commits into from Mar 8, 2023

Conversation

mrkaiser
Copy link
Contributor

@mrkaiser mrkaiser commented Feb 5, 2023

πŸ€” What's changed?

Bug Fix for concatenated regex strings in pythonLanguage

⚑️ What's your motivation?

Bugs are bad

🏷️ What kind of change is this?

  • πŸ› Bug fix (non-breaking change which fixes a defect)

♻️ Anything particular you want feedback on?

πŸ“‹ Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

Tree-Sitter does not clean up concatnated strings. This yields odd bugs
were line broken regexes with or (|) will not work, but just on the line
broken part. The `pythonLanguage` now cleans this without modifying the
internal regex structure and only on nodes with a concat type.
@mrkaiser
Copy link
Contributor Author

@aslakhellesoy any updates here? Appreciate any and all comments

@mrkaiser mrkaiser merged commit c460b33 into main Mar 8, 2023
@mrkaiser mrkaiser deleted the fix_concat branch March 8, 2023 01:49
@mattwynne
Copy link
Member

πŸ‘

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants