Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: java concatenated strings in definitions and generic decorators #202

Merged
merged 4 commits into from
Apr 20, 2024

Conversation

kieran-ryan
Copy link
Sponsor Member

@kieran-ryan kieran-ryan commented Apr 20, 2024

🤔 What's changed?

  • Added support for generic And and But annotations in cucumber-jvm

    import io.cucumber.java.en.And;
    import io.cucumber.java.en.But;
    
    public class StepDefinitions {
        @And("^a regexp$")
            void a_regexp() {
        }
    
        @But("an {undefined-parameter}")
            void an_undefined_parameter(Date date) {
        }
    }
  • Fixes an issue where concatenated strings in step definition patterns were not support with cucumber-jvm

    import io.cucumber.java.en.Given;
    
    public class StepDefinitions {
        @Given(
            "the " + "bee's "
            + "knees")
            void the_bees_knees(Date date) {
        }
    }

⚡️ What's your motivation?

🏷️ What kind of change is this?

  • 🐛 Bug fix (non-breaking change which fixes a defect)

♻️ Anything particular you want feedback on?

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@kieran-ryan kieran-ryan added the 🐛 bug Defect / Bug label Apr 20, 2024
@kieran-ryan kieran-ryan self-assigned this Apr 20, 2024
@kieran-ryan kieran-ryan marked this pull request as ready for review April 20, 2024 19:59
@kieran-ryan kieran-ryan merged commit ac97508 into main Apr 20, 2024
6 checks passed
@kieran-ryan kieran-ryan deleted the java-generic-decorators branch April 20, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Defect / Bug
Projects
None yet
1 participant