-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow showing detail of every example, simplify examples table #159
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not have a big knowledge of that code base
From what I can see, it looks good
Just missing an entry in the changelog, and maybe an update of the readme :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me :)
🤔 What's changed?
This PR makes it so that:
This is achieved by optionally passing a pickle to the
GherkinSteps
- if present then data and results will be scoped to this rather than aggregated from all matching pickles.⚡️ What's your motivation?
Fixes #79. Fixes #77.
This ability to separate the individual pickles and their results from an outline will also allow us to start exposing the retry concept in #75.
🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
The visual design and UX. Clicking the rows to drill down makes sense but isn't very obvious. Maybe a little button at the end of the row as well?
Also, this is a breaking change in part because the name and shape of some components has changed:
HookList
->HookSteps
StepList
->GherkinSteps
There's then a new component
StepsList
which is purely the<ol>
with styling - previously the styles for this were split acrossBackground
andScenario
.@aslakhellesoy not sure how its used in other tools but I don't see much utility in
GherkinSteps
(formerly calledStepList
) from being customisable - it really just loops over the steps and renders aGherkinStep
for each one, no presentational stuff of its own. Does this need to be customisable?Also worth saying this isn't going to be any more helpful than before if the failure is in a background step. We could also include the background steps in the detail if we wanted though.
📋 Checklist:
This text was originally generated from a template, then edited by hand. You can modify the template here.