Makes Chunk directory configurable #41
Conversation
progress.go
Outdated
| if err != nil { | ||
| return "", fmt.Errorf("could not get current user: %w", err) | ||
| func getChunkDirectory(custom string) (string, error) { | ||
| d := os.Getenv("CHUNK_DIR") |
There was a problem hiding this comment.
Shouldn't this variable be named dir instead? As we use the dir variables on other functions and it represents the same meaning and directory
There was a problem hiding this comment.
Given the small scope of the function (15 lines), I'm OK with d — but offer no resistance to change it either lol.
To cite @biancarosa:
Their scope is tiny, the code block that its used is tiny. You can see right where it ends. You don’t have to scroll down too much.
On a more general rule, your variables names should grow according to its scope. Don’t go all crazy and use
cinstead oflineCountfor package variables.
| @@ -67,6 +67,7 @@ var ( | |||
| chunkSize int64 | |||
| waitBetweenRetries time.Duration | |||
| restartDownloads bool | |||
| progressDir string | |||
There was a problem hiding this comment.
Don't you need to set progressDir at Downloader (i.e., line 50)?
There was a problem hiding this comment.
Ooops. Sure thing! Done in 3c17cdf
progress.go
Outdated
| if err != nil { | ||
| return "", fmt.Errorf("could not get current user: %w", err) | ||
| func getChunkDirectory(custom string) (string, error) { | ||
| d := os.Getenv("CHUNK_DIR") |
There was a problem hiding this comment.
Please move this to after check custom (i.e., line 26).
Closes #39